Remove support for table@align=abscenter/absmiddle/middle

RESOLVED FIXED in mozilla2.0b1

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla2.0b1
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 439534 [details] [diff] [review]
Patch v1

No other browser supports those values, and we only support them in quirks mode, so this should be fine to remove.
Attachment #439534 - Flags: review?(Olli.Pettay)

Comment 1

7 years ago
I've used some of those values, so
I'm not 100% sure whether we should remove them.

Jonas, Boris, David, any comments?
(Assignee)

Comment 2

7 years ago
I'm wondering, did you use them on table, or on tr/td/th?
The current HTML5 draft seems to say that these attributes should in fact do something.  See http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#alignment this part of the stylesheet:

  table[align=center], table[align=abscenter],
  table[align=absmiddle], table[align=middle] { /* case-insensitive */
    margin-left: auto; margin-right: auto;
  }

Are you sure no other browser supports these values?  If so, how did they end up in HTML5?

Updated

7 years ago
Attachment #439534 - Flags: review?(Olli.Pettay)

Comment 4

7 years ago
Comment on attachment 439534 [details] [diff] [review]
Patch v1

Based on http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#alignment clearing the review request.
(Assignee)

Comment 5

7 years ago
Created attachment 439776 [details]
Testcase

(In reply to comment #3)
> The current HTML5 draft seems to say that these attributes should in fact do
> something.  See
> http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#alignment
> this part of the stylesheet:
> 
>   table[align=center], table[align=abscenter],
>   table[align=absmiddle], table[align=middle] { /* case-insensitive */
>     margin-left: auto; margin-right: auto;
>   }
> 
> Are you sure no other browser supports these values?

Based on this testcase, Chrome, Opera and IE8 don't support them.

> If so, how did they end up in HTML5?

Not sure. I filed a bug to have them removed from HTML5, but Hixie didn't want to drop them before we did, and that's why I filed this bug.
<http://www.w3.org/Bugs/Public/show_bug.cgi?id=9442>
(Assignee)

Comment 6

7 years ago
Created attachment 442147 [details] [diff] [review]
Patch v2 (merged to tip)

Patch didn't apply anymore...
Attachment #439534 - Attachment is obsolete: true
Attachment #442147 - Flags: review?(bzbarsky)
If we're the only ones that support them, then I say lets just nuke them. Should be easy to get the spec changed if the only browser that supports them has removed support on trunk. Hixie has in the past wanted browsers to take the first step and has then let the spec follow.
Yes, I'm definitely for removing these if no other browser supports them.
For what it's worth. I'm not sure it's worth having tests for *not* supporting a feature.
Comment on attachment 442147 [details] [diff] [review]
Patch v2 (merged to tip)

Stealing review from bz. And yeah, I'd say leave the tests out (in this rare case!).
Attachment #442147 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 11

7 years ago
Created attachment 444110 [details] [diff] [review]
Patch v3 (without test)

Sure. Thanks for the review.
Attachment #442147 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/e824d25382f7
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5

Updated

7 years ago
Target Milestone: mozilla1.9.3a5 → mozilla1.9.3a6
(Assignee)

Updated

7 years ago
Flags: in-testsuite-

Comment 13

6 years ago
http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#tables

This is not yet removed from the spec
(Assignee)

Comment 14

6 years ago
Thanks for the reminder, I've reopened the spec bug.
(Assignee)

Comment 15

5 years ago
And it has been fixed.
You need to log in before you can comment on or make changes to this bug.