559834 - Remove support for table@align=abscenter/absmiddle/middle

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

No other browser supports those values, and we only support them in quirks mode, so this should be fine to remove.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I've used some of those values, so
I'm not 100% sure whether we should remove them.

Jonas, Boris, David, any comments?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'm wondering, did you use them on table, or on tr/td/th?

Comment 3

[Boris Zbarsky [:bzbarsky]]

The current HTML5 draft seems to say that these attributes should in fact do something.  See http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#alignment this part of the stylesheet:

  table[align=center], table[align=abscenter],
  table[align=absmiddle], table[align=middle] { /* case-insensitive */
    margin-left: auto; margin-right: auto;
  }

Are you sure no other browser supports these values?  If so, how did they end up in HTML5?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 439534 [details] [diff] [review]
Patch v1

Based on http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#alignment clearing the review request.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Testcase

(In reply to comment #3)
> The current HTML5 draft seems to say that these attributes should in fact do
> something.  See
> http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#alignment
> this part of the stylesheet:
> 
>   table[align=center], table[align=abscenter],
>   table[align=absmiddle], table[align=middle] { /* case-insensitive */
>     margin-left: auto; margin-right: auto;
>   }
> 
> Are you sure no other browser supports these values?

Based on this testcase, Chrome, Opera and IE8 don't support them.

> If so, how did they end up in HTML5?

Not sure. I filed a bug to have them removed from HTML5, but Hixie didn't want to drop them before we did, and that's why I filed this bug.
<http://www.w3.org/Bugs/Public/show_bug.cgi?id=9442>

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2 (merged to tip)

Patch didn't apply anymore...

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

If we're the only ones that support them, then I say lets just nuke them. Should be easy to get the spec changed if the only browser that supports them has removed support on trunk. Hixie has in the past wanted browsers to take the first step and has then let the spec follow.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes, I'm definitely for removing these if no other browser supports them.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

For what it's worth. I'm not sure it's worth having tests for *not* supporting a feature.

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 442147 [details] [diff] [review]
Patch v2 (merged to tip)

Stealing review from bz. And yeah, I'd say leave the tests out (in this rare case!).

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v3 (without test)

Sure. Thanks for the review.

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e824d25382f7

Comment 13

[j.j.]

http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#tables

This is not yet removed from the spec

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks for the reminder, I've reopened the spec bug.

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And it has been fixed.