Closed Bug 559862 Opened 13 years ago Closed 13 years ago

Oversized dropdown elements on Litmus

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Maemo
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: whimboo, Assigned: vingtetun)

References

()

Details

(Whiteboard: [MobFx1.1Betatestday])

Attachments

(2 files, 2 obsolete files)

Attached image screenshot
Fennec 1.1a2pre

When opening the above URL with Fennec on Maemo, you will notice that all the dropdown elements are drawn oversized. I will attach a screenshot.

Steps:
1. Open https://litmus.mozilla.org/run_tests.cgi?test_run_id=35
2. Login
3. Check dropdown elements
Attached patch Patch (obsolete) — Splinter Review
The patch define the size of the arrow dynamically depending on the size of the select
Attachment #439824 - Flags: review?(mark.finkle)
Comment on attachment 439824 [details] [diff] [review]
Patch

As seen on IRC, this approach can't work with noscript.
Attachment #439824 - Flags: review?(mark.finkle)
Attached patch Patch v0.2 (obsolete) — Splinter Review
Well, the style is not perfect but this correct the oversized dropdown which is nice.
Attachment #439824 - Attachment is obsolete: true
Attachment #440000 - Flags: review?(mark.finkle)
A test would be nice to make sure such a fundamental change doesn't regress anything.
Flags: in-testsuite?
Comment on attachment 440000 [details] [diff] [review]
Patch v0.2

Yes, the oversized part is fixed. The arrow is not centered in the smaller size though.
Attachment #440000 - Flags: review?(mark.finkle) → review+
Comment on attachment 440000 [details] [diff] [review]
Patch v0.2

Sorry. I changed my mind. I think we should spend some time and try to center the SVG before landing this patch.
Attachment #440000 - Flags: review+ → review-
Whiteboard: [MobFx1.1Betatestday] → [MobFx1.1Betatestday] mobile-triage
Whiteboard: [MobFx1.1Betatestday] mobile-triage → [MobFx1.1Betatestday]
Attached patch Patch v0.3Splinter Review
This patch address comments and also correct some content.css regressions on trunk (no more arrows on select elements :s)
Attachment #440000 - Attachment is obsolete: true
Attachment #449614 - Flags: review?(mark.finkle)
Attachment #449614 - Flags: review?(mark.finkle) → review+
As seen on IRC, i've filed bug 559862 as a followup to use calc() instead of
top: 35% once calc has landed
http://hg.mozilla.org/mobile-browser/rev/435719d9cefd
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Thanks for that fix. Works nicely. Marking as verified fixed.
Status: RESOLVED → VERIFIED
Component: Linux/Maemo → General
OS: Linux → Linux (embedded)
QA Contact: maemo-linux → general
You need to log in before you can comment on or make changes to this bug.