559862 - Oversized dropdown elements on Litmus

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: screenshot

Fennec 1.1a2pre

When opening the above URL with Fennec on Maemo, you will notice that all the dropdown elements are drawn oversized. I will attach a screenshot.

Steps:
1. Open https://litmus.mozilla.org/run_tests.cgi?test_run_id=35
2. Login
3. Check dropdown elements

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch define the size of the arrow dynamically depending on the size of the select

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 439824 [details] [diff] [review]
Patch

As seen on IRC, this approach can't work with noscript.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Well, the style is not perfect but this correct the oversized dropdown which is nice.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

A test would be nice to make sure such a fundamental change doesn't regress anything.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 440000 [details] [diff] [review]
Patch v0.2

Yes, the oversized part is fixed. The arrow is not centered in the smaller size though.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 440000 [details] [diff] [review]
Patch v0.2

Sorry. I changed my mind. I think we should spend some time and try to center the SVG before landing this patch.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.3

This patch address comments and also correct some content.css regressions on trunk (no more arrows on select elements :s)

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

As seen on IRC, i've filed bug 559862 as a followup to use calc() instead of
top: 35% once calc has landed

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/435719d9cefd

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Thanks for that fix. Works nicely. Marking as verified fixed.