Open Bug 559932 Opened 14 years ago Updated 2 years ago

Intermittent content/html/document/test/test_bug445004.html | uncaught JS exception - TypeError: uri.match(...) is null at content/html/document/test/test_bug445004.html:50

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox16 --- wontfix
firefox17 --- wontfix
firefox18 --- wontfix
firefox19 --- wontfix
firefox-esr10 --- wontfix
firefox-esr17 --- wontfix

People

(Reporter: tnikkel, Assigned: hiro)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled][leave open])

Attachments

(2 files, 1 obsolete file)

The diff
2.79 KB, patch
Details | Diff | Splinter Review
The revised patch
893 bytes, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1271450931.1271451690.31648.gz
Rev3 Fedora 12x64 mozilla-central opt test mochitests-1/5 on 2010/04/16 13:48:51
s: talos-r3-fed64-017
44130 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug445004.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - uri.match(/^http:\/\/([a-z.0-9]*)/) is null at http://mochi.test:8888/tests/content/html/document/test/test_bug445004.html:49

44090 INFO Running /tests/content/html/document/test/test_bug445004.html...
44091 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected hostname
44092 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected port; fix testcase
44093 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44094 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44095 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44096 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44097 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44098 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44099 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44100 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44101 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44102 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44103 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44104 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44105 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44106 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44107 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44108 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44109 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44110 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44111 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44112 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44113 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44114 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44115 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44116 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Must have start or end
44117 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected base URI for bug445004-outer-rel.html
44118 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected inner base URI for bug445004-outer-rel.html
44119 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected hostnames for bug445004-outer-rel.html
44120 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected base URI for test bug445004-outer-rel.html when testing direct location
44121 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected base URI for test bug445004-outer-rel.html when testing direct write
44122 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Incorrect hostname for bug445004-outer-rel.html direct write
44123 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected base URI for test bug445004-outer-rel.html when testing indirect location
44124 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected base URI for test bug445004-outer-rel.html when testing indirect write
44125 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Incorrect hostname for bug445004-outer-rel.html indirect write
44126 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected base URI for test bug445004-outer-rel.html when testing direct image load
44127 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected base URI for
44128 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected inner base URI for
44129 INFO TEST-PASS | /tests/content/html/document/test/test_bug445004.html | Unexpected hostnames for
44130 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/document/test/test_bug445004.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - uri.match(/^http:\/\/([a-z.0-9]*)/) is null at http://mochi.test:8888/tests/content/html/document/test/test_bug445004.html:49
Summary: intermittent mochitest-plain 1/5 failure in content/html/document/test/test_bug445004.html → intermittent content/html/document/test/test_bug445004.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - uri.match(/^http:\/\/([a-z.0-9]*)/) is null
I noticed that the number of "Must have start or end" in log (at least last two logs) is fewer than expected. The number should be 40 (it was 32 in the last log) so I suppose that all of iframes had not been loaded yet at the time of starting this test.

Boris, thank you for that review, please review this too since you are the author of this test code. 
Thank you,
Attachment #506644 - Flags: review?(bzbarsky)
Hmm.  This test was purposefully trying to not assume things about the number of frames, as much as possible, or their internal structure.  I'd like to preserve that....

Does just starting |loads| equal to 1 and calling loadEnded() in the onload handler of the toplevel page fix things?
Is it confirmed that this test failure is caused by bug 579846?  I cannot locally reproduce.  Could bug 628422 be related to this one?  Please, also check bug 579846 comment 85.
(In reply to comment #29)
> Hmm.  This test was purposefully trying to not assume things about the number
> of frames, as much as possible, or their internal structure.  I'd like to
> preserve that....

I know it, but I did not conceive any other ways.

> Does just starting |loads| equal to 1 and calling loadEnded() in the onload
> handler of the toplevel page fix things?

I tried, and no. It got the same error. Actually "about:blank" was in uri.
(In reply to comment #30)
> Is it confirmed that this test failure is caused by bug 579846?  I cannot
> locally reproduce.  Could bug 628422 be related to this one?  Please, also
> check bug 579846 comment 85.

I am not sure exactly but this test should not be affected by the fix for bug 579846.
This test *was* beyond a reasonable doubt affected by bug 579846 - it has only happened twice in 8 months without the bug 579846 patch (comment 0 and comment 3) and every other instance was with the bug 579846 patch, both on the tryserver and on mozilla-central. It happened, what, 19 times yesterday between midnight and the time that bug 579846 was backed out; it happened 0 times in the same period today.
(In reply to comment #32)
> (In reply to comment #30)
> > Is it confirmed that this test failure is caused by bug 579846?  I cannot
> > locally reproduce.  Could bug 628422 be related to this one?  Please, also
> > check bug 579846 comment 85.
> 
> I am not sure exactly but this test should not be affected by the fix for bug
> 579846.

I meant this test should rewrite not to be affected by the fix for bug 579846 because the aim of this test is different.
> I tried, and no. It got the same error. Actually "about:blank" was in uri.

Which frame was checkFrame running on at the time?

I don't really see how this can happen: the toplevel page's onload should not fire before the subframes have at least all loaded and kicked off their tests....
(In reply to comment #35)
> > I tried, and no. It got the same error. Actually "about:blank" was in uri.
> 
> Which frame was checkFrame running on at the time?

In several trials, it was the first one or second one, num is 0 or 1. And both of cases fail on checking location.href.

> I don't really see how this can happen: the toplevel page's onload should not
> fire before the subframes have at least all loaded and kicked off their
> tests....

Then, there are other issues around onload event or setting location?
Can I see a diff of you attempt to track load of the topmost page?
Attached patch The diff — — Splinter Review 
Sorry for ugly debug codes.
Ah.  That diff is definitely wrong.  You need to leave in the window.addEventListener bit.  If you uncomment that line again, how do things look?
(In reply to comment #39)
> Ah.  That diff is definitely wrong.  You need to leave in the
> window.addEventListener bit.  If you uncomment that line again, how do things
> look?

Ooops, I see now your point. Now it works well. I will revise the previous patch soon.
Attached patch The revised patch — — Splinter Review 
I hope this patch works fine.
Attachment #506644 - Attachment is obsolete: true
Attachment #507022 - Flags: review?(bzbarsky)
Attachment #506644 - Flags: review?(bzbarsky)
Comment on attachment 507022 [details] [diff] [review]
The revised patch

Yeah, like that.  Thanks!
Attachment #507022 - Flags: review?(bzbarsky) → review+
Assignee: nobody → hiikezoe
http://hg.mozilla.org/mozilla-central/rev/1044b021f34c
Keywords: checkin-needed
Target Milestone: --- → mozilla2.0b11
Seeing as we're starring the new failure as this, might as well morph the bug to match what we're starring in it.
Summary: intermittent content/html/document/test/test_bug445004.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - uri.match(/^http:\/\/([a-z.0-9]*)/) is null → Intermittent content/html/document/test/test_bug445004.html | uncaught JS exception - TypeError: uri.match(...) is null at content/html/document/test/test_bug445004.html:50
Whiteboard: [orange]
Too many failures; no one looking at this -> test disabled:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e39465fd16
Whiteboard: [test disabled][leave open]
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Component: DOM → DOM: Core & HTML
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: