559971 - Rename LOpcode enums in NativeARM.cpp

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Comment 1

[Edwin Smith]

Attachment: Automatic rename plus manual alignment fixes.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 443612 [details] [diff] [review]
Automatic rename plus manual alignment fixes.

>-        case LIR_fadd:      FADDD(rr,ra,rb);    break;
>-        case LIR_fsub:      FSUBD(rr,ra,rb);    break;
>-        case LIR_fmul:      FMULD(rr,ra,rb);    break;
>-        case LIR_fdiv:      FDIVD(rr,ra,rb);    break;
>+        case LIR_addd:      FADDD(rr,ra,rb);    break;
>+        case LIR_subd:      FSUBD(rr,ra,rb);    break;
>+        case LIR_muld:      FMULD(rr,ra,rb);    break;
>+        case LIR_divd:      FDIVD(rr,ra,rb);    break;

FADDD et al are no longer appropriate.  I don't know why the 'D' suffix was
already there... would ADDD et al suffice?

r=me with that fixed, the rest looks fine.

Comment 3

[Edwin Smith]

I believe those are the correct names for the ARM instructions.  there's FADD for float and FADDD for double.

Comment 4

[Nicholas Nethercote [inactive]]

(In reply to comment #3)
> I believe those are the correct names for the ARM instructions.  there's FADD
> for float and FADDD for double.

Oh, ok.  Leave them as is then!

Comment 5

[Jacob Bramley [:jbramley]]

Comment on attachment 443612 [details] [diff] [review]
Automatic rename plus manual alignment fixes.

Looks sensible to me.

The double-precision instructions do indeed get a "D" suffix, though we tend to deal in UAL/ARMv7 notation where possible, which would be "VADD.F64". I didn't see any value in changing all the macro names so the old-style names persist!

Comment 6

[Edwin Smith]

NJ: http://hg.mozilla.org/projects/nanojit-central/rev/f7a0d7ffe073

Comment 7

[Edwin Smith]

TR: http://hg.mozilla.org/tamarin-redux/rev/44a5219a43bc

Comment 8

[Nicholas Nethercote [inactive]]

TM: http://hg.mozilla.org/tracemonkey/rev/e090f2679b68

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/e090f2679b68