Closed Bug 559977 Opened 10 years ago Closed 10 years ago

Rename LOpcode enums in Nativei386.cpp

Categories

(Core Graveyard :: Nanojit, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Future

People

(Reporter: edwsmith, Unassigned)

References

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: 504506
passes NJ and TR tests.
Assignee: nobody → edwsmith
Status: NEW → ASSIGNED
Attachment #440203 - Flags: review?(nnethercote)
I'll postpone this review until my last minute bikeshedding over at bug 504506 has been resolved...
Attachment #440203 - Attachment is obsolete: true
Attachment #440203 - Flags: review?(nnethercote)
Automated patch plus a few hand-done indentation fixes
Attachment #441805 - Flags: review?(nnethercote)
Target Milestone: --- → Future
Comment on attachment 441805 [details] [diff] [review]
Rename LIR opcodes in Nativei386.cpp

 rb); break;
>+            case LIR_rshi:       SAR(rr, rb); break;
>+            case LIR_rshui:       SHR(rr, rb); break;

Nit: unaligned indentation.

The rest looks fine.
Attachment #441805 - Flags: review?(nnethercote) → review+
http://hg.mozilla.org/projects/nanojit-central/rev/62e0adc4d69e
Whiteboard: fixed-in-nanojit
http://hg.mozilla.org/tracemonkey/rev/f49dca159319
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
TR: http://hg.mozilla.org/tamarin-redux/rev/ffaa48a9203e
Assignee: edwsmith → nobody
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
http://hg.mozilla.org/mozilla-central/rev/f49dca159319
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.