Closed Bug 559977 Opened 10 years ago Closed 10 years ago
Rename LOpcode enums in Nativei386
No description provided.
passes NJ and TR tests.
Assignee: nobody → edwsmith
Status: NEW → ASSIGNED
Attachment #440203 - Flags: review?(nnethercote)
I'll postpone this review until my last minute bikeshedding over at bug 504506 has been resolved...
Automated patch plus a few hand-done indentation fixes
Attachment #441805 - Flags: review?(nnethercote)
Comment on attachment 441805 [details] [diff] [review] Rename LIR opcodes in Nativei386.cpp rb); break; >+ case LIR_rshi: SAR(rr, rb); break; >+ case LIR_rshui: SHR(rr, rb); break; Nit: unaligned indentation. The rest looks fine.
Attachment #441805 - Flags: review?(nnethercote) → review+
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
Assignee: edwsmith → nobody
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.