Closed
Bug 559977
Opened 15 years ago
Closed 15 years ago
Rename LOpcode enums in Nativei386.cpp
Categories
(Core Graveyard :: Nanojit, defect)
Core Graveyard
Nanojit
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: edwsmith, Unassigned)
References
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)
Attachments
(1 file, 1 obsolete file)
|
30.77 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•15 years ago
|
||
passes NJ and TR tests.
|
||
Comment 2•15 years ago
|
||
I'll postpone this review until my last minute bikeshedding over at bug 504506 has been resolved...
|
|
Reporter | |
Updated•15 years ago
|
Attachment #440203 -
Attachment is obsolete: true
Attachment #440203 -
Flags: review?(nnethercote)
|
|
Reporter | |
Comment 3•15 years ago
|
||
Automated patch plus a few hand-done indentation fixes
Attachment #441805 -
Flags: review?(nnethercote)
|
|
Reporter | |
Updated•15 years ago
|
Target Milestone: --- → Future
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 441805 [details] [diff] [review]
Rename LIR opcodes in Nativei386.cpp
rb); break;
>+ case LIR_rshi: SAR(rr, rb); break;
>+ case LIR_rshui: SHR(rr, rb); break;
Nit: unaligned indentation.
The rest looks fine.
Attachment #441805 -
Flags: review?(nnethercote) → review+
|
|
Reporter | |
Comment 5•15 years ago
|
||
Whiteboard: fixed-in-nanojit
|
|
||
Comment 6•15 years ago
|
||
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
|
|
Reporter | |
Comment 7•15 years ago
|
||
Assignee: edwsmith → nobody
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
|
||
Comment 8•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•