560201 - Sort out editor's contextmenu/mouse event handling

Status: NEW

(Core :: DOM: Editor, defect, P5)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

spun out from bug 558970 comment 6.

> NS_IMETHODIMP
> nsHTMLEditorEventListener::MouseDown(nsIDOMEvent* aMouseEvent)
> {

>   // Detect only "context menu" click
>   //XXX This should be easier to do!
>   // But eDOMEvents_contextmenu and NS_CONTEXTMENU is not exposed in any event interface :-(
>   PRUint16 buttonNumber;
>   nsresult res = mouseEvent->GetButton(&buttonNumber);
>   if (NS_FAILED(res)) return res;
> 
>   PRBool isContextClick;
> 
> #if defined(XP_MAC) || defined(XP_MACOSX)
>   // Ctrl+Click for context menu
>   res = mouseEvent->GetCtrlKey(&isContextClick);
>   if (NS_FAILED(res)) return res;
> #else
>   // Right mouse button for Windows, UNIX
>   isContextClick = buttonNumber == 2;
> #endif

We may be able to optimize this method only for click event handling if we listen contextmenu event.

Comment 1

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=5 years untouched DOM/Storage bugs' priority.

If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.