560235 - background image in print-specific style sheet not printed and not displayed in print preview

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Ilja Sekler]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100419 Firefox/3.7a5pre
Build Identifier: 

In print preview and when printing the test URL with background images enabled as described in Bug 464982, the background image showing the rating of the event by the reviewer (<http://www.daskulturradio.de/kul/grafik/icons/k4.gif>) is not displayed in print preview and subsequently also not printed.

Regression window:

works in <http://hg.mozilla.org/mozilla-central/rev/9af2a428dcb1>

fails in <http://hg.mozilla.org/mozilla-central/rev/2000e14d36b2>

<http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2009-12-10+23%3A38%3A00&enddate=2009-12-11+12%3A58%3A00>

Caused by Bug 487667??


Reproducible: Always

Steps to Reproduce:
1. Set all *print_bgimages preferences to 'true'
2. Load <http://www.daskulturradio.de/rezensionen/buehne/2010/philharmonie_dso.html>
3. Do print preview
4. Print the page (e.g. to a file)

Actual Results:  
The background image with the rating (KKKK) is not displayed after Step 3 and not printed after Step 4.


Expected Results:  
The background image is visible in print preview and appears in the printout.

1.9.2 branch is not affected.

Could test only on Linux.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I was testing background image printing while writing the patch for Bug 487667.
But certainly possible that there is something to fix.

Taking and I'll try to look at this asap.

Comment 2

[Timothy Nikkel (:tnikkel)]

The problem background image (the one at the bottom of the review, at the ones at the top) is applied with a slightly different rule in the screen vs print style sheet, might be something related to that.

Comment 3

[Ilja Sekler]

(In reply to comment #2)
> The problem background image [...] is applied with a slightly different rule
> in the screen vs print style sheet, might be something related to that.

The difference is

.k4 { background: url(../grafik/icons/k4.gif) no-repeat 6.3em .3em; }

in the screen style sheet vs

.k4 { background:url(../grafik/icons/k4.gif) no-repeat 6.3em 1em; padding-top: .6em; }

in the print one. I saved the page locally (which was quite cumbersome due to Bug 115107 and Bug 126309 still open) and played around with these rules. Unfortunately, k4.gif is not printed even if the rule for screen, adjusted to match the location of k4.gif in the locally saved page, is applied to print.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

A minimal testcase would be great here.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I mean something attached using "Add an attachment".

Comment 6

[Ilja Sekler]

Attachment: tgz archive with a minimal testcase

If a background image is explicitly loaded from a style sheet for media="print", it is not printed.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Smaug, this seems like something we need to fix, if it's as general as it sounds.  Do we need to do something different about dealing with image loading for rules that match for the first time when we're printing?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This should bring back the old behavior.

Eventually we may want to load images for printing in a different way,
but for FF4 this is hopefully enough.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 480952 [details] [diff] [review]
patch

r=dbaron, I suppose, although I wonder whether we should pass the original document through more of the code (e.g., do this in nsCSSCompressedDataBlock::MapRuleInfoInto and have assertions elsewhere).  This is probably simpler, though, so r=dbaron.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/d9460f7bf881