Closed
Bug 560311
Opened 14 years ago
Closed 14 years ago
incomplete history observer impl in browser_bug503832.js
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
People
(Reporter: mak, Assigned: philikon)
Details
Attachments
(1 file)
|
937 bytes,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
this docshell test is missing onDeleteVisits, please check it.
|
||
Comment 1•14 years ago
|
||
It does have an onPageExpired which, presumably, should be changed http://hg.mozilla.org/mozilla-central/rev/1a6355f9da5a
|
Reporter | |
Comment 2•14 years ago
|
||
absolutely.
|
Assignee | |
Comment 3•14 years ago
|
||
onPageExpired was replaced with onDeleteVisits as part of bug 520165 (part 8).
Attachment #440518 -
Flags: review?(bzbarsky)
|
||
Comment 4•14 years ago
|
||
Comment on attachment 440518 [details] [diff] [review] Fix along the same lines of bug 520165, part 8 I don't think bz will have a problem with me reviewing this trivial change on this test (I'm a places peer at least). r=sdwilsh
Attachment #440518 -
Flags: review?(bzbarsky) → review+
|
|
||
Updated•14 years ago
|
|
||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/4f2c2898fabe
You need to log in
before you can comment on or make changes to this bug.
Description
•