Closed
Bug 560471
Opened 15 years ago
Closed 15 years ago
remove GC_LAST_DITCH and GC_KEEP_ATOMS
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
12.44 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•15 years ago
|
||
Straightforward implementation that replaces the last ditch and keep atoms with explicit autorooting.
Assignee: general → igor
Attachment #440181 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #440181 -
Flags: review? → review?(jorendorff)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 440181 [details] [diff] [review]
v1
This looks excellent, but please rebase to tip and r?me again.
Attachment #440181 -
Flags: review?(jorendorff)
|
|
Assignee | |
Comment 3•15 years ago
|
||
Here is a rebased patch
Attachment #440181 -
Attachment is obsolete: true
Attachment #440995 -
Flags: review?(jorendorff)
|
|
||
Updated•15 years ago
|
Attachment #440995 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•15 years ago
|
||
It looks like this patch introduced a GC hazard. Here's a sample assertion occuring on the js reftest debug boxes:
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1272062165.1272062456.14697.gz&fulltext=1#err1
|
|
||
Updated•15 years ago
|
Whiteboard: fixed-in-tracemonkey
|
||
Comment 6•15 years ago
|
||
This also might have caused bug 561539..
|
|
Assignee | |
Comment 7•15 years ago
|
||
I have landed a followup to fix the regression - http://hg.mozilla.org/tracemonkey/rev/8e1084fb0cff
Whiteboard: fixed-in-tracemonkey
|
|
||
Comment 8•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•