560480 - [mai] Search engine setup for Firefox for Maithili.

Status: RESOLVED FIXED

(Mozilla Localizations :: mai / Maithili, defect)

Description

[Axel Hecht [:Pike]]

We want to ship Firefox 3.6 a good list of search engines for Maithili. 

We're going to work towards this in three phases. First, the localization team and Stas (Stas Malolepszy) will look at the market for the language and come up with a good set of search providers. Rajesh, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Firefox/Productization>. It'd be good to know how much of the work for Hindi in bug 384408 applies to Maithili.

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:
Google, Yahoo, Amazon, Answers, CC, eBay, Wikipedia

After we decided on a particular search engine, Stas will contact the owner and ask for permission, and for specifics like proper search flags. Rajesh, we'll likely need your help to at least get the contact information.

Once we have a specification on what the searchengines for Maithili should look like, the localization team and Stas will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Stas. After a successful review, the localization team will land them.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Stas, Axel or someone else appointed by Stas or SethB. The data here is sensitive to users and our search partners, thus the extra care here.

Comment 1

[Rajesh Ranjan]

We need to make it just like Hindi for Search Engine!

Comment 2

[Seth Bindernagel]

Hi Rajesh,  If you would like the search plugins for Maithili to be the same as the Hindi version, you can create a patch an check it into the Maithili repository on Mozilla Central when that repository is ready.  Right now, we are still working on getting Maithili ready on Mozilla-Central.

Comment 3

[Axel Hecht [:Pike]]

FWIW, I just imported the latest version from hg into l10n-central, http://hg.mozilla.org/l10n-central/mai/pushloghtml?changeset=a62f3a774dcd, and mai is building now towards fx4, too. With nightlies coming tomorrow, I missed out on today's.

Comment 4

[Rajesh Ranjan]

(In reply to comment #2)
> Hi Rajesh,  If you would like the search plugins for Maithili to be the same as
> the Hindi version, you can create a patch an check it into the Maithili

I need same as Hindi. Please suggest if I need to create patch for fx4 only or for 3.6 as well.

Comment 5

[Seth Bindernagel]

(In reply to comment #4)
> (In reply to comment #2)
> > Hi Rajesh,  If you would like the search plugins for Maithili to be the same as
> > the Hindi version, you can create a patch an check it into the Maithili
> 
> I need same as Hindi. Please suggest if I need to create patch for fx4 only or
> for 3.6 as well.

Please make a patch for l10n-central that will be used for Firefox 4.  We will not ship Maithili for Firefox 3.6 since Firefox 4 is just around the corner.

Comment 6

[Rajesh Ranjan]

thanks. this is better.

Comment 7

[Rajesh Ranjan]

Attachment: patch for review for Maithili

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 505739 [details] [diff] [review]
patch for review for Maithili

r-, this breaks the build, yahoo-in.xml is missing.

And, as this is already landed as part of a mega landing in http://hg.mozilla.org/l10n-central/mai/diff/32c7aade9376/browser/searchplugins/list.txt, the builds are now broken.

Side remark, which wikipedia is best to use for Maithili? I don't see that it has its own instance, so we could stick with English, or does Hindi make more sense?

Comment 9

[Rajesh Ranjan]

Maithili wikipedia community is there but no result yet. Better we would like to go for Hindi till wikipedia Maithili is not coming!

Comment 10

[Rajesh Ranjan]

http://hg.mozilla.org/l10n-central/mai/rev/ccd16005bfca

mistakenly above one I committed after making required changes. Very Sorry!

Please review it!

Comment 11

[Seth Bindernagel]

Rajesh, there is a problem with the list.txt files.  I see two of them in your repository here:

http://hg.mozilla.org/l10n-central/mai/file/default/browser/searchplugins

I think you will want to remove completely the file that says, "list.txt~"

Comment 12

[Rajesh Ranjan]

Thanks Seth. Done!

Comment 13

[Seth Bindernagel]

Is this bug ready to be closed then?  Resolve it fixed if you can.

Comment 14

[Milos Dinic [:Milos]]

Rajeesh, Sangeeta,

Do you want to change something in here? en-US currently ships with twitter in the set of default search engines, so you may want to add it to, in case you think Maithili users would like that?

Comment 15

[Rajesh Ranjan]

twitter should be added!

Comment 16

[Milos Dinic [:Milos]]

Rajesh, so to add twitter, you'd need to add just that, `twitter` to your list.txt. As this is one liner, I don't think you'll need to ask for a review. So, go ahead with changes, push to mozilla-aurora, and then paste the link to revision here, so we can close the bug.

Thanks!

Comment 17

[Milos Dinic [:Milos]]

Rajeesh,

Do you need any help with this? As I said, this would include only one line change to your current /browser/searchplugins/list.txt file, review from me/axel, and push. After this, we should close this bug.

Comment 18

[Rajesh Ranjan]

Sorry Milos for being late. I just fonnd taht my hg account is deactivated. Just filed a bug. I will commit the changes as soon as I got access again in hg.

Comment 19

[Rajesh Ranjan]

I pushed the change in aurora. Please check.

Comment 20

[Milos Dinic [:Milos]]

rev http://hg.mozilla.org/releases/l10n/mozilla-aurora/mai/rev/7969bb5f5725

Looks good, r+. But please, from now on, attach a patch before committing and ask me/axel for a review.

Thanks, Rajesh!