Closed Bug 560492 Opened 15 years ago Closed 15 years ago

[ast] Search engine setup for Firefox 3.6 for Asturian.

Categories

(Mozilla Localizations :: ast / Asturian, defect)

Product:
Mozilla Localizations
Component:
ast / Asturian
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

References

(
URL
)

Details

(Keywords: productization)

Attachments

(1 file, 5 obsolete files)

Fixed descritpion for Uiquipedia suggest
961 bytes, patch
stas
: review+
Details | Diff | Splinter Review
We want to ship Firefox 3.6 a good list of search engines for Asturian. We're going to work towards this in three phases. First, the localization team and Stas (Stas Malolepszy) will look at the market for the language and come up with a good set of search providers. Iñigo, Marcos, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Firefox/Productization>. For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives: Google, Yahoo, Amazon, Answers, CC, eBay, Wikipedia After we decided on a particular search engine, Stas will contact the owner and ask for permission, and for specifics like proper search flags. Iñigo, Marcos, we'll likely need your help to at least get the contact information. Once we have a specification on what the searchengines for Asturian should look like, the localization team and Stas will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Stas. After a successful review, the localization team will land them. Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Stas, Axel or someone else appointed by Stas or SethB. The data here is sensitive to users and our search partners, thus the extra care here.
Component: Other → ast-ES / Asturian
Hi! We believe that the best search engines for the Asturian are: Google > http://www.google.es Yahoo > http://es.yahoo.com Amazon > http://www.amazon.com CC > http://search.creativecommons.org eBay > http://www.ebay.es Uiquipedia > http://ast.wikipedia.org Diccionariu ALLA > http://www.academiadelallingua.com/diccionariu/ "Diccionariu ALLA" means "Dictionary of Academy of the Asturian Language". Could be possible add this entry in the search engines, please? Best regards!
QA Contact: ast
We typically group search into three subject areas: 1. General Purpose 2. eCommerce 3. Special Interest And, we choose 2 for each group for a total of 6. You have provided 7. I might recommend that we eliminate one. How does this look? 1. General Purpose Google Yahoo! 2. eCommerce Amazon eBay 3. Special Interest Uiquipedia Diccionariu ALLA We can also choose CC, but I wonder how much relevant Asturian Creative Commons content there is. Do you know?
Hi Seth! Your suggestions are perfect! ;) 1. General Purpose Google Yahoo! 2. eCommerce Amazon eBay 3. Special Interest Uiquipedia Diccionariu ALLA Thanks!
OK, Stas and I will work on this next week. We will need to get permission from Uiquipedia and Diccionariu ALLA to include them in our browser version. Can you research who those contacts would be? The contacts should be listed on the websites. When you find them, can you send me the contact information to my email address? sethb@mozilla.com
Hi Seth! I send you an email now with the contacts ;) One point about Uiquipedia contact: The Uiquipedia servers are of Wikimedia Fundatión http://www.wikimedia.org/ The most important person for the Asturian Uiquipedia is "Jesus". Is all right? Best regards and thanks!
Hi! "Jesus" is a bureaucrat for Asturian Wikipedia. You can contact with him is is personal page: http://ast.wikipedia.org/wiki/Usuariu:Esbardu Jesus is also known in Uiquipedia as: Esbardu As marcos said, the Uiquipedia servers are of Wikimedia Fundation http://www.wikimedia.org/ , so I think is better contact with them
I've emailed Uiquipedia and Diccionariu ALLA for permissions.
Seth, did you get any responses from Uiquipedia or Diccionariu ALLA?
Hi! Yes Axel, Yes replied ;) They're agree :) Best regards.
@Axel Do you need the confirmation emails? Seth & I have it, I can forward the emails to you :)
Sorry for the delay. Let's pick things up again. Marquinos, can you take a chance at attaching xml search plugin files to this bug? We need one for Yahoo, eBay, Amazon, Uiquipedia and Diccionariu ALLA. This page should be a good resource for you: https://wiki.mozilla.org/L10n:Toolbox/Creating_a_search_plugin We can probably copy the Yahoo! and eBay plugins from es-ES, but not Google. http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/es-ES/file/95c09c52d2e0/browser/searchplugins You'll need to create the Amazon, Uiquipedia and Diccionariu ALLA plugin since es-ES doesn't ship with those. You can take a look at an Amazon plugin here: http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/en-GB/file/a0ad9490e9b0/browser/searchplugins/amazon-en-GB.xml But, please note, this is the *en-GB* version and we should create one for your users, probably pointing them to the es-ES site. Does that seem right to you? For Google however, it is better to rely on Google's language/geo detection. We can use the default plugin as found in en-US file. Consequently, we only need to make sure list.txt lists 'google' - and if it does, the plugin will be copied over from en-US automatically during the build process.
Hi Seth! I attach the search plugins for the Asturian. We have some issues about your request: - alla.xml I can't use accents. Can you review this, please? Thanks! - Google: Google don't recognize the Asturian language, and the english version isn't the correct for the asturian people. Google.es is the best in this case. I attach google-es.xml too. - Amazon: Not exist Amazon for Spain. The most correct is Amazon UK. Best regards!
Attached file ast search plugins (obsolete) —
The page encoding is ISO-8859-1, and the search plugin should specify the same encoding.
I changed it, and same result :(
Can you try method="POST" ?
@Axel Same result :( I think the web is wrong in this point.
Hello! Any news about the problem with the ALLA search engine? I think is a problem of the ALLA web. Any help, please? Thanks in advance! :)
I tested again and continue to hit the same problem. Is this a problem with the ALLA website? If so, we may not be able to ship the plugin. Marquinos, it might be best for you to contact the site. I forwarded you a message from someone who approved Mozilla's use of the search plugin in the ast version of Firefox. Have you tried to email that person? I might recommend you do that so we can see if they have a response.
@Seth: Sent ;) You're in cc. I think this will not be in a shot time, I recommend waiting a bit, and remove it. And if they fix in the future, include it. Thanks! and best regards!
I have not seen any response from the Diccionariu ALLA. We should consider looking for an alternative. I propose that we drop Diccionariu ALLA. As for Amazon, we have noticed that there is not an Amazon intended for Spanish users. Is there another popular e-commerce site that we should use? We should also drop Amazon for a better option. If there is not a better option, we should probably not include Amazon at all. Can you send us your thoughts on these proposals?
@Seth: I'm very agree with your proposals ;) Diccionariu ALLA replied (I forwarded you Mon, Jul 19, 2010 at 2:06 PM from my another email) ;) They will work in it, but we don't know when they will fix it. My proposal: Drop Diccionariu ALLA and Amazon now. Best regards! :)
Final search engines (Resume): 1. General Purpose Google Yahoo! 2. eCommerce eBay 3. Special Interest Uiquipedia
With this change, we will only ship with four search plugins right now. It would be very nice if we could find *one* more search engine to include. Do you have any other suggestions? If not, we can go with just this set. Can you remove the ALLA and Amazon from the patch and flag for a final review from me or Stas? Be sure to amend the list.txt file and include that with your patch. Remember, there is no need for a Google plugin. After the r+, we can check in only the yahoo.es, ebay, and uiquipedia plugins to your to the /ast/file/.../browser/searchplugins file in your Hg repository. Feel free to ask any questions along the way if you need help. As you know, a good reference for you is the es-ES repository.
@Seth: Hi! No more search engines for an asturian user. Removed ALLA & Amazon and attachment to this bug (ast-search-plugins_version2). I didn't include the Google plugin in that archive, please, remember that it's the Spanish version of Google ;) www.google.es for the asturian users. What is "r+"? :P I don't understand. Sorry. Thanks very much!
Assignee: nobody → sethb
Flags: in-testsuite+
Hi! Uploaded to hg the 3 files, and updated the list.txt file. Please, could you check if all is done right? Thanks very much!!! :D
Mind pointing us to a link to the changeset you pushed? Also resetting a few bug changes, please be careful to change flags and stuff. I guess you shouldn't touch the bug flags for a while. The bug assignee is the person that's in charge of providing the fixes to the bug, which in this case would rather be you than Seth.
Assignee: sethb → nobody
Flags: in-testsuite+
@Axel: I'm so sorry, I changed for this Seth point: "flag for a final review from me or Stas?". I will not change any flag more :$ Best regards.
Attachment #451558 - Attachment is obsolete: true
Attachment #460008 - Attachment is obsolete: true
Hi! They replied! Great news :D With another URL it works ;) I attach the final xml files (included Diccionariu ALLA). In a few hours (today) I will update the list.txt file in hg repostory. Thanks very much!
Can you please create a patch for review before committing? hg add the xml files, and then do an hg diff -g and attach the output to the bug. Please make sure to check the 'patch' checkbox, and set the review flag to '?', and the requestee to sethb@moz (that completes). If you have more changes in your tree, restrict the patch to just the search plugins by doing the diff on that dir, for example hg diff -g browser/searchplugins Thanks.
@Axel: I will try this afternoon, I'm not now in my home ;) Wait 5 hours, please :) Thanks!
I just tested the new Diccionariu ALLA and it works nicely. I retested the other three search plugins again as well. Next, I'd recommend the following set of commands: 1) Change the list.txt file in your local repository to match the set of plugins 2) Into your local working repository, check-in these search plugins and the new list.txt. 3) In your local working directory, type "hg status" -- This will output all changed files, as well a "?" next to files that are not yet tracked by hg (these need to be added manually via an 'hg add'). 4) Type "hg add" -- This will add all new files (for example the search plugins you copied). You can also try running 'hg addremove' instead (see 'hg help addremove' for details). 5) Type "hg diff > changes.diff" -- This will create a file called "changes.diff" with all the changes you checked in locally 6) Attach "changes.diff" in this bug for final review. With an approval on that changes.diff file, we can move forward and push the changes to you Mozilla Hg repository. We are almost there, so please keep up the good work.
Marquinos, the instructions that Axel wrote and the ones that I wrote effectively do the same thing. :)
@Seth: OK ;)
Done! Do I need to do anything else? :) Cheers!
Comment on attachment 460547 [details] [diff] [review] The changes with the new Diccionariu ALLA search engine Yep, let's request review from sethb on this, as stas is on vacation.
Attachment #460547 - Flags: review?(sethb)
(In reply to comment #41) > Comment on attachment 460547 [details] [diff] [review] > The changes with the new Diccionariu ALLA search engine > > Yep, let's request review from sethb on this, as stas is on vacation. Looks like Marquinos already checked in the changes to his Hg repo? http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ast/file/default/browser/searchplugins Marquinos, tust to restate *this* part of the process (as found in Comment 0 of this bug): "This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Stas. After a successful review, the localization team will land them." We like to review this part of the process because it involves Mozilla working with third parties. It should be reviewed and approved at all times before checking it in directly to the Hg repo. We'll look at it now. If there are any problems, I'll be sure to mention what we need to do to correct them. Thanks!
Hi! I have just tried all the plugins (YahooES, EbayES, WikiAST, DiccionariuALLA) and everything is perfect :) Best regards.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
I updated the mercurial branch too. The problem was this: The Asturian Wikipedia was named as: "Uiquipedia", and if I visit the Uiquipedia webpage, the site suggest me add the search engine "Uiquipedia (ast)". I fixed rename the search engine "Uiquipedia" to "Uiquipedia (ast)", and this solved the suggest ;) Best regards.
Attachment #460478 - Attachment is obsolete: true
Attachment #460547 - Attachment is obsolete: true
Attachment #460547 - Flags: review?(sethb)
Comment on attachment 464421 [details] [diff] [review] Fixed descritpion for Uiquipedia suggest This looks good, thanks. I saw that you landed that already in Mercurial. In the future, please first wait for an r+ on the patch :)
Attachment #464421 - Attachment description: The diff update → Fixed descritpion for Uiquipedia suggest
Attachment #464421 - Flags: review+
Attachment #464420 - Attachment is obsolete: true
@stas: Sorry ;) In the future I will wait :) I think Asturian Firefox is perfect now! :D
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: