Closed Bug 560562 Opened 10 years ago Closed 10 years ago

Active tab difficult to distinguish from inactive tabs

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3.7a5

People

(Reporter: fehe, Assigned: dao)

References

Details

(Keywords: polish, regression)

Attachments

(5 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100420 BetterPrivacy-1.47 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100420 BetterPrivacy-1.47 Minefield/3.7a5pre

With the "New Style for Tabs" check-in, it is now difficult toe tell which is active tab -- especially on Windows XP Classic Theme.  Please make the active easily distinguishable.


Reproducible: Always
Blocks: 549061
Keywords: polish
Version: unspecified → Trunk
Summary: Active tab difficult to distinguish → Active tab difficult to distinguish from inactive tabs
Do you have a screenshot of what it looks like under Windows XP Classic?
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 500401
Why is this duped to a near year-old Mac OS X bug when this issue arose from a change committed recently for Windows theme?  They are not the same.
Status: RESOLVED → UNCONFIRMED
Keywords: regression
Resolution: DUPLICATE → ---
Summary: Active tab difficult to distinguish from inactive tabs → [Windows XP] Active tab difficult to distinguish from inactive tabs
this is actually where it should be duped to
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 500401
No.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Attached image Windows XP Tabs Mockup
The thinking was to have the active tab much lighter and the background tabs darker. I may have screwed that up by posting two moderately different styles on the mockups page.

This might be a separate issue still because we wanted to target the major XP themes individually and I don't know if we can do that yet: bug 543910
Dão, this actually started when tabs were put in the toolbar.
Here's what the active tab looked like prior to landing of bug 549061.  The active tab had bolded text, which made it stand out better.  It wasn't perfect, but was at least better than it is now.

That said, it looks like bug 543910 is concerned with remedying some of this issue.
Depends on: 543910
No longer depends on: 543910
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100420 Minefield/3.7a5pre ID:20100420040941

works in the 20100316 Win32 nightly
broken in the 20100317 Win32 nightly
to blame: bug 347930

my bad I didn't report this at the time, but it was so obvious that I assumed a bug would be filed by many others on XP
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached image screenshot
top to bottom:
today
march 17
march 16

after march 16 the difference between tab-color for active non-active and hover: is virtually nil
The bolding that has been removed since has only added to the problem

FYI, the most-right tab is the active one
Summary: [Windows XP] Active tab difficult to distinguish from inactive tabs → Active tab difficult to distinguish from inactive tabs
This is on top of the patch in bug 457187.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #440382 - Flags: review?(gavin.sharp)
No longer blocks: 549061
Depends on: 457187
Attachment #440382 - Flags: review?(gavin.sharp) → review+
Comment on attachment 440382 [details] [diff] [review]
increase the contrast

rs=me...
http://hg.mozilla.org/mozilla-central/rev/33acb0b9b1ec
Status: ASSIGNED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
Verified Fixed: http://hg.mozilla.org/mozilla-central/rev/33acb0b9b1ec
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100427 Minefield/3.7a5pre ID:20100427232453

Though I feel having a weird-looking monkey sitting on the tab, clanging cymbals, would have been much more visible. :p
Status: RESOLVED → VERIFIED
I have only one concern with this fix, though.  Instead of simply making the active tab lighter, you also made the inactive tabs darker.  Was this really necessary?  

It just makes the black text on gray background contrast worse.  Here I'm thinking of those whose sight is not so good with distinguishing black on gray, and this darkening is heading in the wrong direction.
this bug is fixed but when TABS ON TOP is selected, it reoccurs. When TABS ON TOP is selected, active tab is difficult to distinguish from inactive tabs. Here is the screenshot: 

http://i.imgur.com/tz9yP.jpg
You need to log in before you can comment on or make changes to this bug.