560572 - Workers: ChromeWorker breaks --disable-ctypes builds

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I didn't realize that we had that option. Need to fix.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Comment 2

[[e-mail]]

Comment on attachment 440265 [details] [diff] [review]
Patch

>diff --git a/dom/src/threads/test/chromeWorker_subworker.js b/dom/src/threads/test/chromeWorker_subworker.js

>-if (!ctypes) {
>-  throw "No ctypes!";
>-}

So this will make tests fail, right? Up to you, but I'm not so sure we want that -- it's gonna add noise for people who don't want a ctypes build and are happy living without the features it provides to other subsystems.

If you think ctypes should be an integral feature of workers in the browser, though -- in effect, a contract -- then I'm fine with it. (Can people disable workers?)

r=me either way.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Yeah, those are "-", not "+", so this works the way you want it to ;)

http://hg.mozilla.org/mozilla-central/rev/f8f6c5be311a

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 440265 [details] [diff] [review]
Patch

>   if (mPrivilegeModel == CHROME) {
>     // Add chrome functions.
>     success = JS_DefineFunctions(aCx, global, gDOMWorkerChromeFunctions);
>     NS_ENSURE_TRUE(success, PR_FALSE);
> 
>+#ifdef BUILD_CTYPES
>     // Add the lazy getter for ctypes.
>     success = JS_DefineProperty(aCx, global, "ctypes", JSVAL_VOID,
>                                 nsDOMWorkerFunctions::CTypesLazyGetter, nsnull,
>                                 0);
>     NS_ENSURE_TRUE(success, PR_FALSE);
>   }
>+#endif

Oh?

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed with http://hg.mozilla.org/mozilla-central/rev/1dbe474226e1