560592 - 'switch task' button doesn't give any push feedback when clicking on it

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

This is what Mark Finkle said in #mobile about it:
<mfinkle>	mw22: we didn't add the "presses" states, iirc
<mfinkle>	"pressed"
mw22: looks like we never added the images for pressed
http://mxr.mozilla.org/mobile-browser/find?string=task-&tree=mobile-browser&hint=
<mfinkle>	those are only for unpressed
<mfinkle>	mw22: please file
<mfinkle>	I guess we could just highlight the background of the buttons
<mfinkle>	n900 actually changes the image too

Comment 1

[Martijn Wargers (dead)]

I think also the close button has this problem. It should also have a blue blackground during the 'mousedown' phase. The same for the 'back' button (the button you get when focusing the url bar).

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Adds the blue highlight background color when the task switch, app close or back buttons are pressed.

Lightweight, simple CSS patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch expands the buttons to the edges and rounds the inner bottom corner.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: screenshot

Screenshot of the button when highlighted

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-b:
http://hg.mozilla.org/mobile-browser/rev/f0c728725029

pushed m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/6107e19ed5ce

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100427 Namoroka/3.6.5pre Fennec/1.1b2pre

and

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100427 Namoroka/3.7a5pre Fennec/1.1b2pre


... with follow-up bug https://bugzilla.mozilla.org/show_bug.cgi?id=562036

Comment 7

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=9758 updated to regression test this bug