The default bug view has changed. See this FAQ.

use Services.jsm in suite glue

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Startup & Profiles
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

unspecified
seamonkey2.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Using the startup component, as suite glue does lots of startup work.

nsSuiteGlue.js uses a ton of services, many of which can be called much more nicely with Services.jsm
(Assignee)

Comment 1

7 years ago
Created attachment 440279 [details] [diff] [review]
convert nsSuiteGlue.js

And here's the patch to do it!

(bug 498596 part 3 will need an update as well, but I already have that locally)
Attachment #440279 - Flags: review?(neil)
(Assignee)

Updated

7 years ago
OS: Linux → All
Hardware: x86 → All

Comment 2

7 years ago
Comment on attachment 440279 [details] [diff] [review]
convert nsSuiteGlue.js

>+    switch (Services.perms.testExactPermission(aRequest.requestingURI, "geo")) {
>       case nsIPermissionManager.ALLOW_ACTION:
I wonder whether we should use Services.perms.ALLOW_ACTION (c.f. prompt)
Attachment #440279 - Flags: review?(neil) → review+
(Assignee)

Comment 3

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/71558cab8b64 with the switch to Services.perms.ALLOW_ACTION etc.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
You need to log in before you can comment on or make changes to this bug.