Last Comment Bug 560593 - use Services.jsm in suite glue
: use Services.jsm in suite glue
Product: SeaMonkey
Classification: Client Software
Component: Startup & Profiles (show other bugs)
: unspecified
: All All
-- normal (vote)
: seamonkey2.1a1
Assigned To: Robert Kaiser
Depends on: 558774
  Show dependency treegraph
Reported: 2010-04-20 11:06 PDT by Robert Kaiser
Modified: 2010-04-22 15:04 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

convert nsSuiteGlue.js (27.70 KB, patch)
2010-04-20 11:41 PDT, Robert Kaiser
neil: review+
Details | Diff | Splinter Review

Description User image Robert Kaiser 2010-04-20 11:06:54 PDT
Using the startup component, as suite glue does lots of startup work.

nsSuiteGlue.js uses a ton of services, many of which can be called much more nicely with Services.jsm
Comment 1 User image Robert Kaiser 2010-04-20 11:41:04 PDT
Created attachment 440279 [details] [diff] [review]
convert nsSuiteGlue.js

And here's the patch to do it!

(bug 498596 part 3 will need an update as well, but I already have that locally)
Comment 2 User image 2010-04-21 04:47:57 PDT
Comment on attachment 440279 [details] [diff] [review]
convert nsSuiteGlue.js

>+    switch (Services.perms.testExactPermission(aRequest.requestingURI, "geo")) {
>       case nsIPermissionManager.ALLOW_ACTION:
I wonder whether we should use Services.perms.ALLOW_ACTION (c.f. prompt)
Comment 3 User image Robert Kaiser 2010-04-22 06:33:14 PDT
Pushed as with the switch to Services.perms.ALLOW_ACTION etc.

Note You need to log in before you can comment on or make changes to this bug.