Closed Bug 560616 Opened 14 years ago Closed 7 years ago

Undisplayed map doesn't perform well with lots of display:none kids

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1296516

People

(Reporter: bzbarsky, Unassigned, Mentored)

References

Details

(Keywords: perf) 

In particular, the append is slow.  Do we really need the check for whether the node is already in the list?  If not, we can just prepend instead of appending or use a CList of some sort.  If we do, can we auto-switch to a hashtable as needed or something?  Or does order matter here?  If it does, then a CList + hashtable is probably the way to go...
Blocks: 559396
Blocks: 441669
Assignee: nobody → bzbarsky
Priority: -- → P1
Blocks: 137577
This really needs a better owner than me...
Assignee: bzbarsky → nobody
Mentor: bzbarsky
See Also: → 1303605
Bug 1296516 refactors the map to use a LinkedList<UndisplayedNode>. So insertions should be O(1) now.
Depends on: 1296516
Assuming bug 1296516 sticks, this should be fixed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
No longer blocks: 559396
You need to log in before you can comment on or make changes to this bug.