560662 - mExpire - leaking in nsNavHistory

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Oleg Romashin (:romaxa)]

We creating it here, but never delete:
http://hg.mozilla.org/releases/mozilla-1.9.2/annotate/aa6fbe509ca6/toolkit/components/places/src/nsNavHistory.cpp#l482

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: fast fix leak

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 440323 [details] [diff] [review]
fast fix leak

Damn, I missed that in review.

r=sdwilsh

Comment 3

[Shawn Wilsher :sdwilsh]

Also curious; why didn't this show up on tinderbox?

Comment 4

[Marco Bonardo [:mak]]

i guess mExpire is a weak pointer, and it probably was before too.

Comment 5

[LegNeato]

Comment on attachment 440323 [details] [diff] [review]
fast fix leak

We will not be taking this for 3.6.6. Mozing approval request forward.

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 440323 [details] [diff] [review]
fast fix leak

moving to next v

Comment 8

[LegNeato]

Comment on attachment 440323 [details] [diff] [review]
fast fix leak

Denying approval for 1.9.2.14 as this missed the non-blocker freeze (yesterday). Feel free to ask for approval for .15, though it won't be granted until we branch for .14.

Comment 9

[Marco Bonardo [:mak]]

this missed various releases, it only affects 3.6.x and it's leaking only on shutdown. I don't think it's still worth to spend time on it.