56072 - Ctrl-shift-left/right arrow doesn't work.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Tobias Burnus]

This is with 2000-10-10-21/Linux (Mozilla nightly) [and is a kind of split of
from bug 55792].
Using ctrl-shift-left/right arrow to select text in the HTML composer doesn't
work. Using ctrl-left/right arrow to navigate works though.
(Navigating using ctrl-home/end doesn't work, selecting via *-shift-* does work,
but this is also broken in <textarea> and in pain Mail Composer and might be
covered by bug 55792)

Comment 1

[Hixie (not reading bugmail)]

Confirmed. This is so annoying! ;-)

Jag: Is this in your field of expertise?

Comment 2

[Kathleen :Brade]

ouch!  not sure how we lost these keybindings.  They work on a mac debug branch 
build today but not on the linux trunk.

Reassign to component Keyboard Navigation.

Comment 3

[johng]

nav triage team:
[rtm-]bummer, but this is just too late in the schedule.

Comment 4

[Martin Horwath]

*** Bug 56617 has been marked as a duplicate of this bug. ***

Comment 5

[Peter "jag" Annema]

Strange. This works fine in the urlbar, yet is broken in composer.

Comment 6

[sairuh (rarely reading bugmail)]

using 2000.11.27.08 mozilla bits on linux, ctrl+shift+left/right do work for me
in the URL bar, but not in composer. am gonna reopen this for that latter case
[unless there's a separate bug for the composer case --currently cannot query
bugzilla, alas].

also noticed that bug 55792 seems to have regressed --will comment there.

Comment 7

[Kathleen :Brade]

change component since this is a Composer-specific issue with keybindings

I see this problem only on Linux (mozilla debug build from today) and only in 
Composer.  I do not see bug #55792 in this same build (no-shift version of this 
bug).  I do not see this bug or bug #55792 on Macintosh debug build from today.

Comment 8

[rubydoo123]

assigning to akkana for initial debugging

Comment 9

[sairuh (rarely reading bugmail)]

will take for qa while sujay is on sabbatical...

Comment 10

[Akkana Peck]

Anthonyd is handling composer key bindings.

Comment 11

[Akkana Peck]

Ah, looks like whoever added that binding to unix/platformHTMLBindings.xml
forgot to add the shift, so it overrides the move word left/right bindings
immediately prior.  Will attach a fix -- Anthony, can you review this? 

Comment 12

[Akkana Peck]

Attachment: Patch: add shift modifier

Comment 13

[timeless]

r=timeless if you want it.

Comment 14

[anthonyd]

good patch, a=anthonyd.

go ahead and check in!

anthonyd

Comment 15

[Peter "jag" Annema]

the prevailing order seems to be "shift,control" instead of "control,shift", but
other than that, r=jag. I had found this one already on one of my journeys
through lxr, unfortunately I forgot to file a bug for it.

Comment 16

[Akkana Peck]

Thanks for the reviews, and the comment.  I'll change it to shift,control before
I check it in (assuming that's okay with everyone).

Comment 17

[Akkana Peck]

Checked in.

Comment 18

[sairuh (rarely reading bugmail)]

my wm at work doesn't play well with keybindings. i'll check this later at home.

cc'ing sujay, in case he can verify this before me. :)

Comment 19

[sujay]

verified in 2/1 build.