560738 - Change Discovery Pane URL

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Justin Scott [:fligtar]]

Jeff wants our URL to have the client parameters in the URL itself. Can we change the URL from

https://services.addons.mozilla.org/%LOCALE%/%APP%/discovery/?appVersion=%APPVERSION%&appOS=%APPOS%#{list of installed GUIDs}

to

https://services.addons.mozilla.org/%LOCALE%/%APP%/discovery/%APPVERSION%/%APPOS%#{list of installed GUIDs}

example: https://services.addons.mozilla.org/en-US/firefox/discovery/3.7/foo?appVersion=3.7&appOS=WINNT#{"[e-mail]","extensions@mossop"}

Thanks!

Comment 1

[Justin Scott [:fligtar]]

sorry, fixed example:
https://services.addons.mozilla.org/en-US/firefox/discovery/3.7/foo#{"[e-mail]","extensions@mossop"}

Comment 2

[Justin Scott [:fligtar]]

Can we land this before the trunk check-in re-try? The currently used URL will be 404 when we push the discovery pane scaffolding this week.

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Sorry Rob, another quick one needed before we reland. This changes the discovery URL to the following on my machine:

https://services.addons.mozilla.org/en-US/firefox/discovery/3.7a5pre/Darwin

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 444448 [details] [diff] [review]
patch rev 1

Dave, no worries whatsoever!

Comment 5

[Dave Townsend [:mossop]]

http://hg.mozilla.org/projects/addonsmgr/rev/793967b887a6

Comment 6

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/08696f911422

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dave, the current URL we are using doesn't list any of the extensions which should be part of the URL as what comment 0 and 1 states. Do we add such a list on the flight?

Comment 8

[Dave Townsend [:mossop]]

(In reply to comment #7)
> Dave, the current URL we are using doesn't list any of the extensions which
> should be part of the URL as what comment 0 and 1 states. Do we add such a list
> on the flight?

Will take care of it in bug 564092

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks. Marking as verified then.