560774 - encapsulate array-related dslots accesses

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

Attachment: patch

This patch encapsulates dslots accesses for dense arrays.  Mostly 
straightforward, except for:

- ResizeSlots() and EnsureCapacity() both got pulled into JSObject, because
  they deal directly with 'dslots'.  Actually the latter () doesn't
  directly access 'dslots', but it knows about the dslots[-1] slot holding 
  the capacity and acts accordingly, so I put it into JSObject.
  
- Changed ResizeSlots() argnames from oldlen/newlen to oldcap/newcap, to 
  match terminology used elsewhere

Comment 1

[Brendan Eich [:brendan]]

Comment on attachment 440418 [details] [diff] [review]
patch

getDenseArrayCapacity
getDenseArrayElem

Seems a bit crufty to drop -ents (or -ent, even shorter than -city) and not match name style by spelling out Element{,s}. r=me with that.

/be

Comment 2

[Nicholas Nethercote [inactive]]

(In reply to comment #1)
> (From update of attachment 440418 [details] [diff] [review])
> getDenseArrayCapacity
> getDenseArrayElem
> 
> Seems a bit crufty to drop -ents (or -ent, even shorter than -city) and not
> match name style by spelling out Element{,s}. r=me with that.

So you want me to change *Elem to Element, and *Elems to *Elements?  (Double-checking because I found that sentence difficult to parse.)

Comment 3

[Brendan Eich [:brendan]]

Yes -- sorry for mixing -rest and {,s} notations ;-).

/be

Comment 4

[Nicholas Nethercote [inactive]]

Pushed with "Elem" changed to "Element" throughout.

http://hg.mozilla.org/tracemonkey/rev/7ead08c80a8a

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/7ead08c80a8a