560831 - Allow theming of highlighter panels in inspector (reticle)

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

The PanelHighlighter should have some theme-able or preference-defined settings to define it's paramaters. The PanelHighlighter will be reimplemented in a subsequent Milestone to be more consistent with the original design document.

see: https://wiki.mozilla.org/Firefox/Projects/Inspector#0.7

Comment 1

[Rob Campbell [:rc] (:robcee)]

Attachment: highlighter-panel-styling

Adding simple styling on highlighter in CSS. Removed style-related methods and constructor from inspector code. Applied after style panel patches in bug 560692.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 441287 [details] [diff] [review]
highlighter-panel-styling

>--- a/browser/base/content/browser.css
>+++ b/browser/base/content/browser.css
>@@ -227,6 +227,9 @@
> #highlighter-panel {
>   -moz-appearance: none;
>   -moz-window-shadow: none;
>+  background: -moz-linear-gradient(top -5deg, #ffdd88, #ffffbb);
>+  border: none;
>+  opacity: 0.35;
> }

None of that belongs in browser/base/.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 441287 [details] [diff] [review]
highlighter-panel-styling

>diff --git a/browser/base/content/browser-inspector.js b/browser/base/content/browser-inspector.js

>   initializeHighlighter: function IUI_initializeHighlighter()
>   {
>-    this.highlighter = new PanelHighlighter(this.browser, this.highlightColor,
>-      this.highlightThickness, this.highlightOpacity);

these properties on InspectorUI should be removed now too, right?

>diff --git a/browser/base/content/browser.css b/browser/base/content/browser.css

> #highlighter-panel {
>   -moz-appearance: none;
>   -moz-window-shadow: none;
>+  background: -moz-linear-gradient(top -5deg, #ffdd88, #ffffbb);
>+  border: none;
>+  opacity: 0.35;
> }

dao's right, these should be in the themes/ browser.css rather than content/.

Comment 4

[Rob Campbell [:rc] (:robcee)]

yes, those properties will go away in a subsequent patch (I think it's in one of the style or DOM panel patches).

The theming on the highlighter panel was temporary. I'll be filing a follow-up bug for a highlighter redesign that should include those things. I stuck those in browser.css for temporary convenience.

Comment 5

[Rob Campbell [:rc] (:robcee)]

this is largely dealt with in bug 560692 and bug 561782. Closing.

Comment 6

[Teodosia Pop]

Verified Fixed using Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0a1) Gecko/20111020 Firefox/10.0a1.