560841 - [bn-BD] sign-off rejected, track required fixes

Status: RESOLVED WORKSFORME

(Mozilla Localizations :: bn-BD / Bengali, defect)

Description

[Axel Hecht [:Pike]]

I've reviewed the sign-off for http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/bn-BD/pushloghtml?changeset=73e899836c3c, and there are regressions that need fixing.

In browser/chrome/browser/aboutSupport.dtd, aboutSupport.pageSubtitle, you lost a reference to brandShortName. The word is still there, but it'll need to be &brandShortName; so that the actual application name like Firefox or Minefield is shown. There's still a ';' somewhere else in the translated sentence, that might be erroneous, too.

In browser/chrome/browser/browser.dtd, fullZoomReduceCmd.commandkey2 and fullZoomResetCmd.commandkey2 ended up with the full key name. Check back on the en-US values, and make sure there's not a tool bug tripping you there. Those should either be empty or just a single key. I bet the actual en-US value serves you right.

The (en-US key) additions sound like a tool-induced unfortunate hack, is that right? Saw them all over browser.dtd, but didn't look in other files. Interestingly they're removed in places.dtd in some strings and added in others?

In browser/chrome/browser/preferences/privacy.dtd, historyHeader.post.label is changed from empty string to key value.

In dom/chrome/security/caps.properties, you translated only a tiny fragment of GetPropertyDeniedOriginsSubjectDomain, that looks irritating a bit.

In toolkit/chrome/global/customizeToolbar.dtd, dialog.style got it's CSS specs translated, that should be undone.

In toolkit/chrome/global/dialog.properties, accesskey-cancel got changed from an empty string to key value. Same for toolkit/chrome/global/intl.properties, intl.menuitems.alwaysappendaccesskeys.

And toolkit/chrome/global/viewSource.dtd, textReduce.commandkey2 and textReset.commandkey2.

And toolkit/chrome/mozapps/help/help.dtd, fullZoomEnlargeCmd.commandkey3 and fullZoomResetCmd.commandkey2.

In toolkit/chrome/mozapps/incompatible.dtd, incompatible.intro and incompatible.suffix, brandShortName lost &;, should still be &brandShortName;.

Looking through the diff, there's surely tons of stuff that is worth having, but any of the regressions above needs to be fixed to take that.

Once you have fixes landed, please pound the nightly builds with some extensive testing, both on the changes that you did as well as just general "dogfood", i.e., use a 1.9.2 nightly for your daily browsing. You can find those on http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-1.9.2-l10n/. Some of the things I found while digging through the changes should have shown up in active testing.

Comment 1

[Jamil Ahmed]

Thanks for pointing out the issues and sorry for not being careful. I will fix the issues and sign-off again after testing with the nightly builds.

Comment 2

[Axel Hecht [:Pike]]

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/bn-BD/pushloghtml?changeset=2be926340ecb has a bunch of these issues fixed, but there are still a few left overs from the "insert key as value" issue.

Here's a list:

./browser/chrome/browser/browser.dtd:  fullZoomReduceCmd.commandkey2, fullZoomResetCmd.commandkey2
./browser/chrome/browser/preferences/privacy.dtd:  historyHeader.post.label

Comment 3

[Jamil Ahmed]

Thanks for pointing out. How do you find them? Is there any tool I can use?

I have fixed those and pushed. Can you please check following revision?

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/bn-BD/pushloghtml?changeset=80ae25cb8a4c

Comment 4

[Axel Hecht [:Pike]]

I guess most of these are fixed by now.