Closed Bug 560867 Opened 10 years ago Closed 10 years ago

test_contextmenu should test for label existence and give slightly better log info

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a5

People

(Reporter: kairo, Assigned: kairo)

Details

Attachments

(1 file)

Not strictly menus, but I hope context menu is close enough. ;-)

In my work for SeaMonkey bug 487692, I ran into a problem that I inadvertently made a goSetMenuValue() fail, which caused a context menu item to end up without a label. I figured it's easy to test for this and it would be valuable to do so.
Also, it would be quite helpful for debugging failures of this test if the access key existence test (as well as this new label test) did say on which menuitem ID the failure occurred.

And, above all, I figured that Firefox should have those test improvements as well, and not just SeaMonkey. ;-)
And here's the very simple patch for this! :)
Attachment #440520 - Flags: review?
Attachment #440520 - Flags: review? → review?(gavin.sharp)
Comment on attachment 440520 [details] [diff] [review]
check for label, tell ID in accesskey check

thanks!
Attachment #440520 - Flags: review?(gavin.sharp) → review+
Pushed as http://hg.mozilla.org/mozilla-central/rev/a269a9d26bfe
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
You need to log in before you can comment on or make changes to this bug.