560867 - test_contextmenu should test for label existence and give slightly better log info

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Robert Kaiser]

Not strictly menus, but I hope context menu is close enough. ;-)

In my work for SeaMonkey bug 487692, I ran into a problem that I inadvertently made a goSetMenuValue() fail, which caused a context menu item to end up without a label. I figured it's easy to test for this and it would be valuable to do so.
Also, it would be quite helpful for debugging failures of this test if the access key existence test (as well as this new label test) did say on which menuitem ID the failure occurred.

And, above all, I figured that Firefox should have those test improvements as well, and not just SeaMonkey. ;-)

Comment 1

[Robert Kaiser]

Attachment: check for label, tell ID in accesskey check

And here's the very simple patch for this! :)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 440520 [details] [diff] [review]
check for label, tell ID in accesskey check

thanks!

Comment 3

[Robert Kaiser]

Pushed as http://hg.mozilla.org/mozilla-central/rev/a269a9d26bfe