560896 - Support addition of approved/ad-hoc Add-ons

Status: RESOLVED FIXED

(Websites Graveyard :: byob.mozilla.com, defect)

Comment 1

[Les Orchard [:lorchard]]

Whoops, submitted before editing a description:

Add-ons

- Ability to include search plug-ins from a recommended list
- Ability to include a limited number of add-hoc plugins (by locale,
optionally)
- Ability to include extensions from a recommended list
- Ability to include ad-hoc extensions
- Inclusion of featured extensions/jetpacks that are specific to BYOB
- Ability to specify a limited number of installed extension-related
preferences
- Ability to include a theme as default or a non-default

Comment 2

[Chris Howse [:chowse]]

First draft mock-ups ready:

  Wireframe:
  http://people.mozilla.com/~chowse/drop/byob/v1/repack-addons.png

  Original:
  http://people.mozilla.com/~chowse/drop/byob/v1/00_byob.graffle.zip


Right now, the designs support:

  * Adding 10+ approved extensions (or any uploaded XPI, for admins).

  * Adding 10+ approved search engines (or any uploaded XPI, for admins),
    and specifying the default search engine.

  * Selecting an approved Persona to use by default.

  * Selecting an approved theme to use by default.

Comment 3

[Les Orchard [:lorchard]]

Starting to take a crack at this... Looks like I've got the extension installer working on the backend, and am no longer unpacking the .xpis to get them into a repack.

Kev: Have you gotten any updates to that extension installer alpha since the one you sent around back in March?

chowse: Do you happen know a way in CSS to get the _/\_ notch in a border to build the sub-tabs in your mockup without using images?  I swore I saw something like that awhile ago, but have forgotten if/where I saw it.

Comment 4

[Chris Howse [:chowse]]

(In reply to comment #3)
> chowse: Do you happen know a way in CSS to get the _/\_ notch in a border to
> build the sub-tabs in your mockup without using images?  I swore I saw
> something like that awhile ago, but have forgotten if/where I saw it.

I wasn't aware you could do this with CSS, but a quick search turned this up:

   http://www.dinnermint.org/css/creating-triangles-in-css/

Take a look at the word bubble example: it uses heavy borders and absolute positioning to produce a triangle with a bottom border.

Comment 5

[Les Orchard [:lorchard]]

Been banging on this for a few days now, and not quite done, but figured it was about time to push some work up to staging.  So, r67382 should be up (mostly) working up there now.

Still have a bit left to do, including:

* Sidebar list of selected add-ons
* Better error handling (eg. invalid persona URL)
* Access control to ad-hoc XPI uploads
* CSS tweaks needed for Safari and other non-Fx browsers

And, I've got some things that I'll need some input on such as:

* Updates to the extension installer extension?  It works, but seems unfinished - causes a restart that misses the first-run page; throws up some weird dialogs on first run, etc.

* What set of extensions, search engines, personas, themes do we want to allow? These are all specified in a config file, so we can change them pretty easily.  (I had wanted to use AMO's collections feature for all of this, but it turns out that collections only support extensions and not any of the other 3 categories.)

But, the process *should* work, from addon selection through to repack build.  Or, at least, it does on my laptop.  I've not yet had a chance to get a repack built on staging.

Comment 6

[Les Orchard [:lorchard]]

Oh yeah, and the review page before submitting a build is a total mess right now too as a result of code shuffling I've been doing... so that's on my TODO list as well.

Comment 7

[David Rolnitzky]

Not seeing in the build...just through the "wizard" screens.

Comment 8

[Les Orchard [:lorchard]]

(In reply to comment #7)
> Not seeing in the build...just through the "wizard" screens.

What aren't you seeing in the build?

Comment 9

[Les Orchard [:lorchard]]

(In reply to comment #6)
> Oh yeah, and the review page before submitting a build is a total mess right
> now too as a result of code shuffling I've been doing... so that's on my TODO
> list as well.

Addons should be appearing in the review screen now, after r67582

Comment 10

[Les Orchard [:lorchard]]

Going to say this is done now, save any bugs found in testing