close #pragma pack

RESOLVED FIXED in mozilla1.9.3a5

Status

()

Core
Graphics
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: (dormant account), Assigned: glandium)

Tracking

Trunk
mozilla1.9.3a5
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Created attachment 440541 [details] [diff] [review]
clean up after #pragma pack

This is busting gcov/pgo on 64bit.
Attachment #440541 - Flags: review?(roc)
(Reporter)

Updated

8 years ago
Keywords: checkin-needed
(Reporter)

Comment 1

8 years ago
http://hg.mozilla.org/mozilla-central/rev/dff91f83bc84
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Updated

8 years ago
Keywords: checkin-needed
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 561018
Depends on: 561022
Depends on: 561021
Apparently this backout fixed bug 561018, bug 561021, and bug 561022 (the dependencies of this bug).
Version: unspecified → Trunk
(Assignee)

Comment 4

8 years ago
Created attachment 440968 [details] [diff] [review]
Patch v2
(Assignee)

Comment 5

8 years ago
Comment on attachment 440968 [details] [diff] [review]
Patch v2

I'll send this to try servers.
Attachment #440968 - Attachment description: Patch → Patch v2
Attachment #440968 - Attachment is patch: true
Attachment #440968 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 6

8 years ago
Created attachment 441061 [details] [diff] [review]
Patch v3

Patch v2 didn't work any better, and as I thought it made no sense that it would fail more on windows than on other platforms, I checked ifdefs... guess what, there is an ifdef XP_WIN bunch of code at the end that uses a struct (defined ouside the ifdef, so I moved it), which is not enclosed with a pragma pack.

I think this new patch should work. Pushed on the try servers.
Assignee: nobody → mh+mozilla
Attachment #440968 - Attachment is obsolete: true
(Assignee)

Comment 7

8 years ago
Comment on attachment 441061 [details] [diff] [review]
Patch v3

It passed win32 unit tests on the try servers, which the previous patch didn't.
Attachment #441061 - Flags: review?(roc)
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/d542ee95ef22
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.