Closed
Bug 560897
Opened 16 years ago
Closed 16 years ago
close #pragma pack
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: taras.mozilla, Assigned: glandium)
References
Details
Attachments
(2 files, 1 obsolete file)
|
596 bytes,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
3.33 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
This is busting gcov/pgo on 64bit.
Attachment #440541 -
Flags: review?(roc)
Attachment #440541 -
Flags: review?(roc) → review+
|
Reporter | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 1•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 2•16 years ago
|
||
Backed out as http://hg.mozilla.org/mozilla-central/rev/badafa282c3d.
|
|
||
Updated•16 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Apparently this backout fixed bug 561018, bug 561021, and bug 561022 (the dependencies of this bug).
|
||
Updated•16 years ago
|
Version: unspecified → Trunk
|
Assignee | |
Comment 4•16 years ago
|
||
|
|
Assignee | |
Comment 5•16 years ago
|
||
Comment on attachment 440968 [details] [diff] [review]
Patch v2
I'll send this to try servers.
Attachment #440968 -
Attachment description: Patch → Patch v2
Attachment #440968 -
Attachment is patch: true
Attachment #440968 -
Attachment mime type: application/octet-stream → text/plain
|
|
Assignee | |
Comment 6•16 years ago
|
||
Patch v2 didn't work any better, and as I thought it made no sense that it would fail more on windows than on other platforms, I checked ifdefs... guess what, there is an ifdef XP_WIN bunch of code at the end that uses a struct (defined ouside the ifdef, so I moved it), which is not enclosed with a pragma pack.
I think this new patch should work. Pushed on the try servers.
Assignee: nobody → mh+mozilla
Attachment #440968 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•16 years ago
|
||
Comment on attachment 441061 [details] [diff] [review]
Patch v3
It passed win32 unit tests on the try servers, which the previous patch didn't.
Attachment #441061 -
Flags: review?(roc)
Attachment #441061 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 8•16 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•