Closed
Bug 560941
Opened 15 years ago
Closed 15 years ago
[OOPP] Fix the Core Graphics Shmem leak
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file, 3 obsolete files)
|
1.20 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
We need to dealloc the Shmem for Core Graphics out of process. We should do this as soon as bug 555275 is fixed.
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Comment 2•15 years ago
|
||
Removed a testing change.
I tested without this patch applied. When Core Graphics is used for OOPP and you resize several times the memory usage increases rapidly without the patch and is steady with the patch.
Attachment #442415 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Attachment #442417 -
Flags: review?(joshmoz)
|
|
Assignee | |
Comment 3•15 years ago
|
||
This patch will reset the width/height. This will safeguard against the code trying to use the Shmem if the resize allocation fails.
Attachment #442417 -
Attachment is obsolete: true
Attachment #442447 -
Flags: review?(joshmoz)
Attachment #442417 -
Flags: review?(joshmoz)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #442447 -
Attachment is obsolete: true
Attachment #442450 -
Flags: review?(joshmoz)
Attachment #442447 -
Flags: review?(joshmoz)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #442450 -
Attachment is patch: true
Attachment #442450 -
Attachment mime type: application/octet-stream → text/plain
Attachment #442450 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/66a7ae163db7
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 6•15 years ago
|
||
Verified using:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100521 Minefield/3.7a5pre
Aggressive 'Zoom in/out' of large Flash OOP with CoreGraphics does not leak memory.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•