560985 - Crash [@ strlen | -[NSXMLTreeReader processRealDocument:] ] in Sparkle's downloadDidFinish:

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We've seen occasional crashes (usually on 10.4) in SUAppcast.m's downloadDidFinish:.

There's a launchpad bug https://bugs.launchpad.net/sparkle/+bug/456514 where Andy added null-checks to downloadFilename in download didFailWithError:, which has similar code structure to downloadDidFinish:.

In a speculative attempt to stop the crash we're seeing, we should add null-checks to downloadFilename in SUAppcast.m.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Adds some null-checking

This patch adds null-checks to the NSXMLDocument creation and to the file manager calls in downloadDidFinish: and adds the null-checks in download didFailWithError: from https://bugs.launchpad.net/sparkle/+bug/456514

Comment 2

[Stuart Morgan]

Comment on attachment 440651 [details] [diff] [review]
Adds some null-checking

sr=smorgan

Sounds like we should do another refresh from Sparkle trunk at some point.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> Sounds like we should do another refresh from Sparkle trunk at some point.

Yeah, assuming it still compiles on 10.4.  Andy just landed delta-updates last month; not sure what sort of instability that might have introduced.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/682f1dc9e453

Also landed on cvs trunk and the CAMINO_2_0_BRANCH in advance of 2.0.3.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The breakpad search URL will age out after a while, but bp-e60becbc-f983-41f0-97c5-d214f2100419 is the sample report I was looking at.