561053 - mochitest-browser-chrome: "browser_feed_tab.js | Number of feeds listed: 0, should be 3"

Status: RESOLVED FIXED

(SeaMonkey :: Feed Discovery and Preview, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1271906572.1271908622.6069.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2010/04/21 20:22:52
{
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_feed_tab.js | Number of feeds listed: 0, should be 3
}

Comment 1

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a5pre) Gecko/20100421 SeaMonkey/2.1a1pre] (comm-central-trunk-win32/1271913096)

Reproducible.

Comment 2

[[e-mail]]

I see three feeds if I open Page Info manually...

Comment 3

[Robert Kaiser]

Do we have a regression range?

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Do we have a regression range?

On
http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey&maxdate=1268186210&hours=24&legend=0&norules=1

Started with
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1008f5c2e057&tochange=b44b60d703d1
then stopped with
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2da8ac54d264&tochange=614a48536800
then again with
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eaf1574b10b6&tochange=29cb33290f7e

Culprit is obviously bug 544097.

Comment 5

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/comm-central/search?string=localhost%3A8888&case=1&find=%2Fsuite%2F
This is the only occurrence of localhost:8888 in c-c.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) s/localhost:8888/mochi.test:8888/ [Checkin: Comment 9]

This fixes it locally.

Comment 7

[Robert Kaiser]

Comment on attachment 440758 [details] [diff] [review]
(Av1) s/localhost:8888/mochi.test:8888/
[Checkin: Comment 9]

ah, sure, that sounds like it!

Thanks for finding and fixing!

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Sorry if I don't know this, but how do changes go from mozilla-central to
comm-central?

This failing test file is not in mozilla-central, so I would not have known
about it.  The patch on this bug is all I would do to fix it.

In the future when I make test harness changes, should they be tested on 
https://build.mozillamessaging.com/try?  Any advice and education on the comm-central testing would be appreciated!

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 440758 [details] [diff] [review]
(Av1) s/localhost:8888/mochi.test:8888/
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/88a03ba7cb78

Comment 10

[Robert Kaiser]

(In reply to comment #8)
> Sorry if I don't know this, but how do changes go from mozilla-central to
> comm-central?

Manually, through having someone doing the patches. If it's not the author of the m-c work, then it's good if someone from our side is watching and/or peing poked about it.

> This failing test file is not in mozilla-central, so I would not have known
> about it.  The patch on this bug is all I would do to fix it.

The latter is good to know, so we should have caught all we need.

> In the future when I make test harness changes, should they be tested on 
> https://build.mozillamessaging.com/try?  Any advice and education on the
> comm-central testing would be appreciated!

Unfortunately, the Thunderbird try server doesn't run tests, so that wouldn't help. Usually the best thing is to have someone from our side CCed on work that could affect us, and ideally check the SeaMonkey tree for changes in test failures (unfortunately, we are not usually green right now, we are still catching up from the time when we had too little machine power to run tests on trunk). If things can affect xpcshell tests or builds, looking at the Thunderbird tree after checkin is also a good idea.

Looking at the trees and filing bugs for oranges is usually already a great help - once we know what caused it and how to fix it, we already know more than in many other cases. ;-)