561265 - Use GetThemeBitmap for drawing native widgets with D2D

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

We can do more efficient drawing if use GetThemeBitmap to build a cache of all of the theme bitmaps and draw them directly with D2D instead of using GDI. Further if we sprite them we can also take advantage of direct2d's ability to draw multiple parts in a single draw call.

The documentation on how to use GetThemeBitmap etc. is pretty sparse but Wine has an implementation of the theme dll which should give a pretty good idea of how this should work.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Drawing theme elements this way would also limit our need for native clipping on GDI.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I think we can use GetThemeMargins and GetThemePartSize to figure out how to draw the theme bitmaps. i.e. to draw a button get the margins and then stretch out the bitmap using a 3x3 grid defined by the margins sort of like "border-image".

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This might help with bug 713532, but I don't know how this would work with animated themes.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

FWIW, Edge does not seem to be using this API anymore. I wonder if we'd be better off just implementing the windows style theme by hand. (This is what Chrome does)

Comment 5

[Gregory Pappas [:gregp]]

Not relevant anymore