Created attachment 441186 [details] [diff] [review] Patch v.1 NSS defines a few things as opaque structs, WeaveCrypto should use the new jsctypes support for this, for slightly better type-safety. Also, I switched voidptr_t to void_t.ptr, since I prefer that syntax and it's been working for a while now.
Attachment #441186 - Flags: review?(dwitte)
Comment on attachment 441186 [details] [diff] [review] Patch v.1 r=dwitte!
Attachment #441186 - Flags: review?(dwitte) → review+
This can land now (or shortly, once tm merges to m-c).
Don't forget to make sure the component won't load on older builds without this support.
Assignee: nobody → dolske
Status: NEW → ASSIGNED
Target Milestone: --- → 2.0
It's been more than a year since the review. Do we still want to land this?
I think if it's still applicable we want to land it! Does it apply cleanly-ish?
sync triage: if still works, land it :)
How does this depend on block 743070, when that block shows it's depending on this to finish?
(In reply to Yev from comment #7) > How does this depend on block 743070, when that block shows it's depending > on this to finish? Bug 743070 will render this bug, and others, unnecessary. If that bug is closed, then this can be, ergo depends on.
Assignee: dolske → nobody
I'm just going to call this wontfix -- WeaveCrypto really isn't under active development, and so this isn't worth the code churn.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.