Use jsctypes opaque struct types.

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
9 years ago
2 months ago

People

(Reporter: Dolske, Unassigned)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 441186 [details] [diff] [review]
Patch v.1

NSS defines a few things as opaque structs, WeaveCrypto should use the new jsctypes support for this, for slightly better type-safety.

Also, I switched voidptr_t to void_t.ptr, since I prefer that syntax and it's been working for a while now.
Attachment #441186 - Flags: review?(dwitte)

Comment 1

9 years ago
Comment on attachment 441186 [details] [diff] [review]
Patch v.1

r=dwitte!
Attachment #441186 - Flags: review?(dwitte) → review+

Comment 2

9 years ago
This can land now (or shortly, once tm merges to m-c).
Don't forget to make sure the component won't load on older builds without this support.
Assignee: nobody → dolske
Status: NEW → ASSIGNED
Target Milestone: --- → 2.0

Comment 4

7 years ago
It's been more than a year since the review. Do we still want to land this?

Updated

7 years ago
Target Milestone: 2.0 → ---
I think if it's still applicable we want to land it! Does it apply cleanly-ish?

Updated

7 years ago
Depends on: 743070
sync triage: if still works, land it :)

Comment 7

6 years ago
How does this depend on block 743070, when that block shows it's depending on this to finish?
(In reply to Yev from comment #7)
> How does this depend on block 743070, when that block shows it's depending
> on this to finish?

Bug 743070 will render this bug, and others, unnecessary. If that bug is closed, then this can be, ergo depends on.
Assignee: dolske → nobody
(Reporter)

Comment 9

6 years ago
I'm just going to call this wontfix -- WeaveCrypto really isn't under active development, and so this isn't worth the code churn.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

2 months ago
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.