561550 - Disabling Events/Tasks checkbox in Print Preview dialog sets calendar to read-only [Error: Bad aItemFilter passed to getItems]

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 1.0b2pre (BuildID: 20100423034217) with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.5pre) Gecko/20100424 Lanikai/3.1b2pre

Disabling Events/Tasks checkbox in Print Preview dialog sets calendar to read-only [Error: Bad aItemFilter passed to getItems]

Steps To Reproduce:
1. Subscribe to a iCalendar (.ics) file
1. Switch to calendar tab and open menu File > Print
2. Disable both Events and Tasks checkbox in the What to Print section

Actual Results:
The ics calendar is set to read-only and marked as not available. Console shows:

  Warning: There has been an error reading data for calendar: TEST. 
  Error code: 0x80004005. Description: Bad aItemFilter passed to getItems

  Warning: There has been an error reading data for calendar: TEST. 
  Error code: READ_FAILED. Description:

Expected Results:
Calendar is not set to read-only.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Eduardo, can you look into this?

Comment 2

[Eduardo Katayama]

(In reply to comment #1)
> Eduardo, can you look into this?
Sure :)

Comment 3

[Martin Schröder [:mschroeder]]

Eduardo, do you still work on fixing this issue?

Comment 4

[Stefan Sitter [:ssitter]]

Eduardo, any progress on this topic? Error still exists using Lightning 1.0b4pre (20110526) with Mozilla/5.0 (Windows NT 6.1; rv:5.0) Gecko/20110526 Thunderbird/3.3a4pre.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Hey Stefan, maybe you can do a quick review of this bug??

Comment 6

[Matthew Mecca [:mmecca]]

Comment on attachment 547399 [details] [diff] [review]
Fix - v1

Looks good. r=mmecca

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/af72e01b189a>
-> FIXED

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/8cd8084c08e9>

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/83ac0012cb06>