561596 - [OS/2]New gfxutils library does not export symbols

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Dave Yeo]

Bug #544099 included splitting off a new library, gfxutils which resulted in missing symbol errors when linking gklayout.dll. Static builds linked fine.
This turns out to be a declspec(export) problem which seems to only affect OS/2.

Comment 1

[Dave Yeo]

Attachment: Add define to allow declspec to work

This simple patch fixes the build here. I don't see how this might hurt other systems but have not tested it on anything besides OS/2.
Asking Mike for review as he created the new library.

Comment 2

[Michael Ventnor]

If this only affects OS/2, could you wrap it with an if or ifdef of some kind to make it only apply to OS/2?

Comment 3

[Michael Ventnor]

Actually, forget it. It's one harmless line.

Comment 4

[Dave Yeo]

(In reply to comment #3)
> Actually, forget it. It's one harmless line.

I didn't bother wrapping it since it is unwrapped in mozilla/gfx/thebes/src/Makefile.in. I'm a little surprised that Windows also doesn't need it.
Thanks for the review.

Comment 5

[Peter Weilbacher]

http://hg.mozilla.org/mozilla-central/rev/6f0fe1119d4b

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Pretty sure that this is causing bug 566049

Comment 7

[Peter Weilbacher]

As discussed in that bug 566049 Mike's assessment was not correct. Since this checkin was only after that bug it would have been surprising...