561638 - Weave Error in Trunk Nightly (Status Bar Icon Missing)

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[WildcatRay]

Starting with today's Minefield Trunk Nightly, the Weave Status Bar icon is missing and it appears that Weave is not loading when the browser starts up. The following error is showing in the Console:

Error: missing ( before formal parameters
Source file: file:///C:/Documents%20and%20Settings/rmurphy/Application%20Data/Mozilla/Firefox/Profiles/(current_profile)/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/service.js
Line: 129, Column: 15
Source code:
  get password password() ID.get("WeaveID").password, 


Trunk Build ID: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100425 Minefield/3.7a5pre - Build ID: 20100425040736

Changeset: 2f01bfd52a75

Comment 1

[Daniel C]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100425 Minefield/3.7a5pre

I also get:

Error: gWeaveWin is undefined
Source File: chrome://browser/content/browser.xul
Line: 1

Error: missing ( before formal parameters
Source File: file:///home/user123/.mozilla/firefox/profilexyz/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/service.js
Line: 129, Column: 15
Source Code:
  get password password() ID.get("WeaveID").password,

Comment 2

[WildcatRay]

(In reply to comment #0)
> Starting with today's Minefield Trunk Nightly, the Weave Status Bar icon is
> missing and it appears that Weave is not loading when the browser starts up.
> The following error is showing in the Console:
> 
> Error: missing ( before formal parameters
> Source file:
> file:///C:/Documents%20and%20Settings/rmurphy/Application%20Data/Mozilla/Firefox/Profiles/(current_profile)/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/service.js
> Line: 129, Column: 15
> Source code:
>   get password password() ID.get("WeaveID").password, 
> 
> 
> Trunk Build ID: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre)
> Gecko/20100425 Minefield/3.7a5pre - Build ID: 20100425040736
> 
> Changeset: 2f01bfd52a75

FYI: This error is triggered when opening the Tools > Options regardless of whether or not the Weave tab is the active tab.

Comment 3

[Mike Connor [:mconnor]]

So the same weave build, on the previous day's nightly, works fine?

Comment 4

[WildcatRay]

For me, it was.

Comment 5

[WildcatRay]

Sorry, I forgot to mention the Weave version. It is 1.2.1.

Comment 6

[Mike Connor [:mconnor]]

Can you install the previous nightly build to verify that's actually the case?  Also, can you try running 1.3b1?

Comment 7

[Daniel C]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100425 Minefield/3.7a5pre

For me, Weave definitely worked in the 20100424 nightly but not in today's. Weave 1.2.1 (same as yesterday).

From:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010-04-24-03-mozilla-central/firefox-3.7a5pre.en-US.linux-i686.txt

To:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010-04-25-03-mozilla-central/firefox-3.7a5pre.en-US.linux-i686.txt

Comment 8

[Daniel C]

As a pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d542ee95ef22&tochange=2f01bfd52a75

(Sidenote, where is the page to generate that? I just copied the URL from another bug and replaced the changesets...)

Comment 9

[JK]

Verified Weave works in 4/24 nightly, breaks in 4/25 on OS X 10.5.8 PPC

Broken Weave isn't in the status bar; selecting it from Tools menu brings up weird 3 button popup for Signin Sync buttons do nothing.

Comment 10

[Alice0775 White]

Please see Bug 561646  - get Operator fails if the (optional) name of the function is specified

Comment 11

[Ed Lee :Mardak]

Yeah, waldo blogged about get/setters changing due to an oddity in spidermonkey in how it parses out function names. This should be fixed by just removing the old explicit name.

Comment 12

[Ed Lee :Mardak]

Attachment: v1

Comment 14

[pepemosca]

Same here with 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100425 Minefield/3.7a5pre (.NET CLR 3.5.30729)

And

weave-1.3b1-dev.xpi

The icon is not in the status bar.
Is not sync-ing.
It show strange icons when I try to see the Options from the Add-Ons.
Doesn't work the Weave tab in Preferences.

Comment 15

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/078ef559662e
Remove the extra name from get/set declarations now that Spidermonkey doesn't want them.

Comment 16

[WildcatRay]

Thanks, 1.2.2 appears to be working fine in both Minefield/Trunk and Fx 3.6.x.