Last Comment Bug 561645 - SeaMonkey part of Toolkit bug 561116
: SeaMonkey part of Toolkit bug 561116
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Autocomplete (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: seamonkey2.1a2
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on: 454531 561116
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-25 08:04 PDT by Serge Gautherie (:sgautherie)
Modified: 2010-05-13 16:28 PDT (History)
2 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1-SM) /suite/browser/navigator.xul [Checkin: Comment 6] (1.17 KB, patch)
2010-04-25 08:11 PDT, Serge Gautherie (:sgautherie)
neil: review+
Details | Diff | Review
(Bv1-TB) /mail/base/content/specialTabs.xul [Checkin: Comment 3] (1.04 KB, patch)
2010-04-25 08:16 PDT, Serge Gautherie (:sgautherie)
standard8: review+
Details | Diff | Review

Description Serge Gautherie (:sgautherie) 2010-04-25 08:04:32 PDT
Bug 561116 comment 17:
{
Serge Gautherie (:sgautherie)      2010-04-24 08:37:24 PDT

(From update of attachment 441284 [details] [diff] [review])
>-    <content>
>+    <content ignorekeys="true" level="top">

Firefox got level="top" from bug 454531.
It looks like we should clean up
http://mxr.mozilla.org/comm-central/search?string=level%3D%22top%22&case=1&find=%5C.xul%24
{
/mail/base/content/specialTabs.xul
    * line 44 -- <panel type="autocomplete" id="PopupAutoComplete" level="top"
/suite/browser/navigator.xul
    * line 149 -- <panel type="autocomplete" id="PopupAutoComplete" level="top"
noautofocus="true"/>
}
while we're here.
}
Comment 1 Serge Gautherie (:sgautherie) 2010-04-25 08:11:59 PDT
Created attachment 441356 [details] [diff] [review]
(Av1-SM) /suite/browser/navigator.xul
[Checkin: Comment 6]
Comment 2 Serge Gautherie (:sgautherie) 2010-04-25 08:16:47 PDT
Created attachment 441357 [details] [diff] [review]
(Bv1-TB) /mail/base/content/specialTabs.xul
[Checkin: Comment 3]
Comment 3 Serge Gautherie (:sgautherie) 2010-05-06 18:04:30 PDT
Comment on attachment 441357 [details] [diff] [review]
(Bv1-TB) /mail/base/content/specialTabs.xul
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/992fba361aea
Comment 4 Serge Gautherie (:sgautherie) 2010-05-06 18:19:10 PDT
Comment on attachment 441356 [details] [diff] [review]
(Av1-SM) /suite/browser/navigator.xul
[Checkin: Comment 6]

db48x doesn't seem to be an active SM reviewer, is he?
Comment 5 Robert Kaiser (not working on stability any more) 2010-05-13 14:41:39 PDT
Comment on attachment 441356 [details] [diff] [review]
(Av1-SM) /suite/browser/navigator.xul
[Checkin: Comment 6]

Yes, I think db48x doesn't really look into SeaMonkey stuff these days. Neil already knows this from his fixing of our sutocomplete, let's make him do it.
Comment 6 Serge Gautherie (:sgautherie) 2010-05-13 16:27:38 PDT
Comment on attachment 441356 [details] [diff] [review]
(Av1-SM) /suite/browser/navigator.xul
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/7ba13fabd645

Note You need to log in before you can comment on or make changes to this bug.