561660 - Do not remove palette of toolbars from DOM tree

Status: UNCONFIRMED

(Toolkit :: Toolbars and Toolbar Customization, enhancement)

Description

[Joachim Herb]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.1.9) Gecko/20100317 Lightning/1.0b2pre Thunderbird/3.0.4 ID:20100317103207

As discussed in bug 519956 comment #158 the palette of a toolbar is removed from the DOM tree. Only a javascript "class" variable is used to save a reference. If the toolbox is now moved around, e.g. by a call to appendChild() this reference is lost. As discussed in bug 519956 comment #159 this seems not necessary. 

Removing this code (http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/toolbar.xml#125) would make it easier to move around toolbars, e.g. when switching the layout of Thunderbird. Also in the CompactHeader add-on the header toolbar is moved between the compact and the full header view.

The same problem appears for other variables: toolbarset, firstPermanentChild, lastPermanentChild.



Reproducible: Always

Comment 1

[Philip Chee]

In our SeaMonkey extended toolbox binding we do this:

http://mxr.mozilla.org/comm-central/source/suite/common/bindings/toolbar.xml#80

80       <field name="palette">
81         this.getElementsByTagName("toolbarpalette").item(0);
82       </field>

Causing the check here to fail:

http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/toolbar.xml#112

112           if (!toolbox.palette) {

Causing the code to remove the toolbarpalette from the DOM to be skipped.