561663 - Help is broken: undefined entity &printCmd.commandkey;

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

With a current trunk nightly, F1 greets me with:

XML Parsing Error: undefined entity
Location: chrome://help/content/help.xul
Line Number 64, Column 5:
    <key id="printKb" key="&printCmd.commandkey;" oncommand="print();"
----^

This is on WinXP and SM started in Safe Mode but I guess that doesn't matter much.

help.xul is actually mozilla/toolkit/components/help/content/help.xul.

Setting regressionwindow-wanted.

Comment 1

[Robert Kaiser]

stefanh just noted this on IRC, he said that the .dtd is missing from the .jar file - I suspect some toolkit change causes us to have a jar.mn packaging issue.

Comment 2

[Stefan [:stefanh]]

This works in the 2010-03-31-00 build and does not work in the 2010-04-01-00 build. Strongest candidate is bug 516758.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #2)
> This works in the 2010-03-31-00 build and does not work in the 2010-04-01-00
> build. Strongest candidate is bug 516758.

Agreed, left a comment there.

Comment 4

[Ian Neal]

Adding the following back in locally seems to fix the issue for me:

@@ -6552,16 +6552,31 @@ else
     if test "x$ac_cv_sqlite_enable_fts3" = "xno"; then
         AC_MSG_ERROR([System SQLite library is not compiled with SQLITE_ENABLE
_FTS3.])
     fi
 fi
 
 AC_SUBST(MOZ_NATIVE_SQLITE)
 
 dnl ========================================================
+dnl = Enable help viewer (off by default)
+dnl ========================================================
+MOZ_ARG_ENABLE_BOOL(help-viewer,
+[  --enable-help-viewer        Enable help viewer],
+    MOZ_HELP_VIEWER=1,
+    MOZ_HELP_VIEWER= )
+if test -n "$MOZ_HELP_VIEWER"; then
+     AC_DEFINE(MOZ_HELP_VIEWER)
+fi
+AC_SUBST(MOZ_HELP_VIEWER)
+if test "$MOZ_BUILD_APP" = "browser" -a -n "$MOZ_HELP_VIEWER"; then
+    AC_MSG_ERROR([Cannot build Firefox with --enable-help-viewer.])
+fi
+
+dnl ========================================================
 dnl = Enable safe browsing (anti-phishing)
 dnl ========================================================
 MOZ_ARG_ENABLE_BOOL(safe-browsing,
 [  --enable-safe-browsing        Enable safe browsing (anti-phishing) implemen
tation],
     MOZ_SAFE_BROWSING=1,
     MOZ_SAFE_BROWSING= )
 if test -n "$MOZ_SAFE_BROWSING"; then
     AC_DEFINE(MOZ_SAFE_BROWSING)

Comment 5

[Justin Wood (:Callek)]

Fixed by http://hg.mozilla.org/mozilla-central/rev/cedd9976e7e0