561664 - document.activeElement should never return native anonymous content

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Currently document.activeElement may return the input element inside type="file". 
Content JS gets then an exception when it tries to access the element.

Comment 2

[Scott González]

This is causing problems for us in jQuery UI. We wrap elements for certain animations, and the wrapping causes elements to lose focus, so we reset focus after wrapping. However, if a file input has focus, then we try setting the focus on the exposed text input, which is no longer in the document (not sure why).

jQuery UI bug: http://bugs.jqueryui.com/ticket/8288
Reduced test case using jQuery UI: http://jsfiddle.net/2efq2/8/
Reduced test case using plain JavaScript/DOM: http://dev-test.nemikor.com/bugs/firefox/input-type-file-activeelement.html

Comment 3

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Attachment: patch

Comment 4

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Comment on attachment 620830 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=52113d2992a5

Comment 5

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Bah, the patch revealed another bug.

Comment 6

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Attachment: +fix to test_bug430351.html

https://tbpl.mozilla.org/?tree=Try&rev=527d379c12aa

Comment 7

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Neil, the patch doesn't change the focusing behavior, but it is just that
test_bug430351.html tests currently  the_native_anon_button_inside_file_input != <input type="file">
With the patch that becomes <input type="file"> != <input type="file">

Comment 8

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

https://hg.mozilla.org/mozilla-central/rev/032d43b1770f