561678 - Make ThebesLayerOGL use platform-optimal drawing surface

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Use Native Surface in ThebesLayerOGL

BeginDraw should return a surface type that works best on that platform for drawing to. The easiest way to do that is to use CreateOffscreenSurface, and then do uploading to GL in a surface type dependent way.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Use Native Surface in ThebesLayerOGL v2

Corrected to use OPERATOR_SOURCE. This should perform faster better.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 441414 [details] [diff] [review]
Use Native Surface in ThebesLayerOGL v2

-    mSoftwareSurface = new gfxImageSurface(gfxIntSize(mInvalidatedRect.width,
-                                                      mInvalidatedRect.height),
-                                           gfxASurface::ImageFormatRGB24);
+    mDestinationSurface =
+      gfxPlatform::GetPlatform()->
+        CreateOffscreenSurface(gfxIntSize(mInvalidatedRect.width,
+                                          mInvalidatedRect.height),
+                               gfxASurface::ImageFormatRGB24);
   } else {
-    mSoftwareSurface = new gfxImageSurface(gfxIntSize(mInvalidatedRect.width,
-                                                      mInvalidatedRect.height),
-                                           gfxASurface::ImageFormatARGB32);
+    mDestinationSurface =
+      gfxPlatform::GetPlatform()->
+        CreateOffscreenSurface(gfxIntSize(mInvalidatedRect.width,
+                                          mInvalidatedRect.height),
+                               gfxASurface::ImageFormatARGB32);

Better to just have one call to CreateOffscreenSurface with a variable format

+      {
+        imageSurface = new gfxImageSurface(gfxIntSize(mInvalidatedRect.width,
+                                                      mInvalidatedRect.height),
+                                           imageFormat);
+        nsRefPtr<gfxContext> tmpContext = new gfxContext(imageSurface);
+        tmpContext->SetSource(mDestinationSurface);
+        tmpContext->SetOperator(gfxContext::OPERATOR_SOURCE);
+        tmpContext->Paint();
+      }

Still quite suboptimal for non-Windows ... Probably should add a comment that you really, really don't want to be taking this default path.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    case gfxASurface::SurfaceTypeWin32Printing:
+      imageSurface =
+        static_cast<gfxWindowsSurface*>(mDestinationSurface.get())->
+          GetImageSurface();

Is it really true that for a Win32Printing surface we can get the image bits like this?