561716 - g_type_init not called by nsMaemoNetworkManager::Startup in the Qt build

Status: RESOLVED FIXED

Description

[James Cook]

In a Qt build the nsMaemoNetworkManager::Startup function (from netwerk/system/maemo/nsMaemoNetworkManager.cpp) does not call g_type_init before calling dbus_connection_setup_with_g_main.  This causes a problem with xpcshell, not allowing for any networking events to be monitored.

Comment 1

[James Cook]

Created attachment 445927 [details] [diff] [review]
A possible answer

I'm not sure this is the right thing to do, but it does cure the problem.  I see that g_type_init is called within toolkit/xre/nsNativeAppSupportQt.cpp, should it be moved?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 445927 [details] [diff] [review]
A possible answer

Passing to doug

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 445927 [details] [diff] [review]
A possible answer

i'd rather see this somewhere lower level, like in toolkit/

http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsNativeAppSupportQt.cpp#60

Comment 4

[Oleg Romashin (:romaxa)]

Created attachment 460139 [details]
nsMaemoNetworkManager::Startup backtrace child process

> i'd rather see this somewhere lower level, like in toolkit/
> 
> http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsNativeAppSupportQt.cpp#60

Problem is that we have this problem on child process, and NativeAppSupport - not started there, and nsMaemoNetworkManager::Startup called without g_type_init...

not sure but I guess nsMaemoNetworkManager::Startup should not start on content process side.

Comment 5

[Oleg Romashin (:romaxa)]

Created attachment 460294 [details] [diff] [review]
Disable network manager on content side

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 460294 [details] [diff] [review]
Disable network manager on content side

this is fine, but you got to give me a comment, man!  irc conversations don't count.

Comment 7

[Doug Turner (:dougt)]

the other thing you should consider is making all network manager stuff only happen in the parent in IPC builds - not just maemo.

Comment 8

[Oleg Romashin (:romaxa)]

Created attachment 460302 [details] [diff] [review]
Is that better?

is it possible already describe in manifest file something like "load in parent only" and prevent even constructor call from comp manager manifest loader?

Comment 9

[Oleg Romashin (:romaxa)]

It would be nice to have such feature in component registration, and tell to component manager that this component should be only loaded in parent or child process ..

Comment 10

[Oleg Romashin (:romaxa)]

(In reply to comment #9)
> It would be nice to have such feature in component registration, and tell to
> component manager that this component should be only loaded in parent or child
> process ..

Benjamin any ideas?

Comment 11

[Doug Turner (:dougt)]

Comment on attachment 460302 [details] [diff] [review]
Is that better?

how about here?

http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsIOService.cpp#276

Comment 12

[Oleg Romashin (:romaxa)]

Created attachment 460434 [details] [diff] [review]
Create mNetworkLinkService only in default process

Comment 13

[Doug Turner (:dougt)]

Comment on attachment 460434 [details] [diff] [review]
Create mNetworkLinkService only in default process

change:

// go into managed mode if we can, and chrome process

to

// go into managed mode if we can.  this should only happen in the parent process.

Comment 14

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/69c18f83cf5d

and

http://hg.mozilla.org/mozilla-central/rev/3ed8f0ce4099 (thanks khuey!)