561734 - Use do_QueryObject

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[[e-mail]]

do_QueryObject replaces:
nsAccUtils::QueryAccessible (2x)
nsAccUtils::QueryAccessibleTable
nsAccUtils::QueryAccessibleDocument (2x)
nsAccUtils::QueryAccessibleTree

Comment 1

[[e-mail]]

Attachment: Proposed patch

Trying multiple addresses in case of mismatches, please cancel incorrect ones.

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> Created an attachment (id=441473) [details]
> Proposed patch
> 
> Trying multiple addresses in case of mismatches, please cancel incorrect ones.

Neil, could you describe this more please? I do not see anything wrong with the patch.

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 441473 [details] [diff] [review]
Proposed patch

Does this have any expected impact? In other words, should I test this, or is this just code cleanup/refactor?

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #3)
> (From update of attachment 441473 [details] [diff] [review])
> Does this have any expected impact? In other words, should I test this, or is
> this just code cleanup/refactor?

It's cleanup.

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 441473 [details] [diff] [review]
Proposed patch

Cancelling my review request.

Comment 6

[[e-mail]]

(In reply to comment #2)
> (In reply to comment #1)
> > Trying multiple addresses in case of mismatches, please cancel incorrect ones.
> Neil, could you describe this more please? I do not see anything wrong with the
> patch.
I wasn't sure who to request or whether I had remembered the correct email addresses (Bugzilla doesn't give you a chance to correct them when you're creating an attachment) so I simply typed in what I could remember.

Comment 7

[alexander :surkov (:asurkov)]

I see :)

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 441473 [details] [diff] [review]
Proposed patch

r=me, thank you for fixing this and thank you for do_QueryObject implementation!

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 441473 [details] [diff] [review]
Proposed patch

r=me, nice 1 thanks.

Comment 10

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/2d1edfb3aaa3

Comment 11

[[e-mail]]

Attachment: Missed some

Sorry for overlooking these. I wonder whether there are any more?

Comment 12

[alexander :surkov (:asurkov)]

Comment on attachment 444252 [details] [diff] [review]
Missed some


> nsTextAccessible::AppendTextTo(nsAString& aText, PRUint32 aStartOffset, PRUint32 aLength)
> {
>   nsIFrame *frame = GetFrame();
>-  NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE);
>+  if (!frame) return NS_ERROR_FAILURE;//NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE);

why is this change?

r=me, thank you for doing this

I think there are no other cases for do_QueryObject

Comment 13

[[e-mail]]

(In reply to comment #12)
> >-  NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE);
> >+  if (!frame) return NS_ERROR_FAILURE;//NS_ENSURE_TRUE(frame, NS_ERROR_FAILURE);
> why is this change?
I've got no idea why that change is there at all. I can only guess it must have been left over from a review of some unrelated patch. Sorry about that.

Comment 14

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 444252 [details] [diff] [review]
Missed some

r=me thanks!

Comment 15

[[e-mail]]

Pushed changeset ce9f07472020 to mozilla-central.