561870 - Enforce min/max limits on viewport values

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

I can see this on Fennec on windows as well as on the n900. Using the 1.92 branch from 2010-04-26.

The tab preview of https://bugzilla.mozilla.org/attachment.cgi?id=440871 shows up black, while the testcase certainly isn't black.

I'm seeing this error in the error console, when that happens:
uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMCanvasRenderingContext2D.drawWindow]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/tabs.xml :: updateThumbnail :: line 61"  data: no]

Comment 1

[Matt Brubeck (:mbrubeck)]

I can't reproduce this in a 1.1b1 candidate build on N900 or in current trunk builds on Linux desktop, though I did see Fennec freeze after opening the testcase in an older 1.9.2 Linux desktop build.

The testcase sets viewport width=9999999999999.  According to this page, the iPhone limits viewport width to 10000px.  We should probably do the same.
http://developer.apple.com/safari/library/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Add checks for the other limits too: height and the scales

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Here's a patch and test case.

I don't know if it fixes the original problem since I haven't managed to reproduce it yet.  I'll try a mobile-1.1 build....

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

it seems to fix the problem I saw

pushed:
http://hg.mozilla.org/mobile-browser/rev/0a0598e61477

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100430 Namoroka/3.6.5pre Fennec/1.1b2pre

and

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100430 Namoroka/3.7a5pre Fennec/1.1b2pre

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/b8c061e975e1