561926 - test harness should allow serving of static files via webserver

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

a web server would help a lot with testing widgets with URL content, or testing the Request module, for example.

we could have a "static" directory under a package's test directory. if that static directory exists, have cuddlefish start the server w/ that dir as root, before it kicks off the test run.

it would have to expose the server URL to the test environment.

Comment 1

[Atul Varma [:atul]]

While I agree with this for integration testing or cases where we aren't able to use mocks/stubs/fakes, I'd also like to note that we should probably also add a mock XHR class to the SDK and encourage folks to use it, particularly since mocks are really fast and can be used to simulate conditions that are potentially difficult to duplicate in practice.

Other than that, though, this sounds like a great idea!

Comment 2

[Atul Varma [:atul]]

Just filed bug 562234 for the mock XHR class, btw.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 5

[Myk Melez [:myk] [@mykmelez]]

asqueella has done this:

http://asqueella.blogspot.com/2011/01/javascript-http-server-as-module-for.html

So we just need to get it into api-utils as a low-level internal module so we can use it in our own unit tests (including some that are already written but are disabled for lack of this functionality).

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

So, https://github.com/mozilla/addon-sdk/pull/258 pulls in asqueella's httpd module, for whoever wants to review it.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Pointer to pull request 258

And a pointer to keep track of it here on bugzilla.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 573272 [details]
Pointer to pull request 258

Thanks for putting this together!  Just a few issues, comments in the pull request.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 573272 [details]
Pointer to pull request 258

Additional review and updates occurred in the pull request, r=myk.