Closed
Bug 56193
Opened 26 years ago
Closed 26 years ago
Cannot delete attachment (Classic only)
Categories
(MailNews Core :: Composition, defect, P2)
MailNews Core
Composition
Tracking
(Not tracked)
VERIFIED
FIXED
M18
People
(Reporter: bugzilla, Assigned: bugzilla)
Details
(Keywords: dataloss, Whiteboard: [rtm++]Fixed in trunk already)
Attachments
(4 files)
|
627 bytes,
patch
|
Details | Diff | Splinter Review | |
|
685 bytes,
patch
|
Details | Diff | Splinter Review | |
|
698 bytes,
patch
|
Details | Diff | Splinter Review | |
|
565 bytes,
patch
|
Details | Diff | Splinter Review |
With the classic theme, I cannot delete attachment apparently because the
attachment pane doesn't get the focus. Works fine with the Modern theme. The
only work arround is to start a new compose window. It's kind of a data loose!
| Reporter | ||
Comment 1•26 years ago
|
||
nominating for RTM, this is really bad and should be very simple to fix, just a
css matter normaly.
| Assignee | ||
Comment 2•26 years ago
|
||
i have a fix...
Assignee: ducarroz → blakeross
Status: ASSIGNED → NEW
| Assignee | ||
Comment 3•26 years ago
|
||
| Assignee | ||
Comment 4•26 years ago
|
||
attached a patch which fixes this and also removes a useless margin setting
(also, it was useless to have these rules apply to the text, so removed that
also). please review.
| Assignee | ||
Comment 5•26 years ago
|
||
aNotes about the patch:
* It would be even longer if I didn't remove #attachmentBucketText because then
I would have had to break the rules up.
* #attachmentBucketText styling is not necessary, nor is margin-left (and
neither are in Modern, either).
Hewitt, could you reveiew? Ben, can you approve?
Comment 6•26 years ago
|
||
r=hewitt on the patch.
| Assignee | ||
Comment 7•26 years ago
|
||
looking it over, it could also just be |#attachmentBucket| (not
|tree#attachmentBucket|). Any reason to use one over the other?
Comment 8•26 years ago
|
||
the 'tree' qualification is unnecessary. Please remove it.
Are you completely sure removing the margin has no visual effect?
If so, a=ben.
| Assignee | ||
Comment 9•26 years ago
|
||
| Assignee | ||
Comment 10•26 years ago
|
||
attached a new patch removing the qualification and readding what I removed.
I'm not positively sure that the margin isn't there for a reason to accomodate
for some mac or linux problem, so to be on the safe side, let's keep it. sorry
for the hassle, Joe can you review again? will then resolicit approval from
Ben (just to be sure..)
Comment 11•26 years ago
|
||
a=ben on the updated patch.
| Assignee | ||
Comment 12•26 years ago
|
||
hewitt, please r= again for the new patch. thanks.
Comment 13•26 years ago
|
||
This needs to get on the PDT's radar RIGHT NOW. We need a rtm+.
Comment 14•26 years ago
|
||
r=hewitt on the updated patch.
| Assignee | ||
Comment 15•26 years ago
|
||
fixed in trunk. if you want to argue that this should be in the branch, reopen
this. you could make the following points:
* This is a form of dataloss, since if the user accidentally clicks on the
wrong file to attach, he will need to trash his compose window, thereby losing
his message subject and body, the list of addresses he was sending it to, and
any previous files he has attached.
* The attached patch is the more correct patch for the trunk, but we could have
a 1-line branch fix with no consequences/side effects.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Keywords: dataloss
Resolution: --- → FIXED
Whiteboard: [rtm+]
| Reporter | ||
Comment 16•26 years ago
|
||
Blake, can you put (again) the one line fix. We really need to convice PDT to
accept it for RTM. I reopen the bug for the branch only. Else the bug won't be
in the PDT radar!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Reporter | ||
Comment 17•26 years ago
|
||
Please PDT, ++ this bug.
Whiteboard: [rtm+] → [rtm+]Fixed in trunk already
| Assignee | ||
Comment 18•26 years ago
|
||
| Assignee | ||
Comment 19•26 years ago
|
||
| Assignee | ||
Comment 20•26 years ago
|
||
OK, I attached a very short, trivial patch which is sufficient for the branch.
The only difference is that the word "Attachments" above the tree will also
take focus if clicked upon, which isn't really an issue at all (no side effects
or consequences, and no real reason why the user would arbitrarily click on
plain text anyways).
If you want to argue this to PDT, you can use the dataloss scenario I
presented. I don't know if this is good enough to get ++, so you might need to
meet with PDT in person.
Comment 21•26 years ago
|
||
Reviewers, please indicate your approval of the latest version of the patch.
In addition, can you describe any possible side-effects of taking this patch?
(There has been concern that even one line changes like this can break things.)
Whiteboard: [rtm+]Fixed in trunk already → [rtm need info]Fixed in trunk already
| Assignee | ||
Comment 22•26 years ago
|
||
Hewitt and Ben, please r= and a= the latest branch patch (last time..really ;-).
I already said the one side effect of the patch, and it doesn't affect
anything. It's just that the "Attachments:" label above the attachments tree
can take focus if clicked upon. That doesn't matter.
Comment 23•26 years ago
|
||
a=ben for the modified patch.
Comment 24•26 years ago
|
||
r=jag
| Assignee | ||
Comment 25•26 years ago
|
||
OK, reviewed and approved fix in hand. marking rtm+
(this should, of course, be ++ since it's more dataloss than 46683 will ever be)
Whiteboard: [rtm need info]Fixed in trunk already → [rtm+]Fixed in trunk already
Comment 26•26 years ago
|
||
rtm++
Whiteboard: [rtm+]Fixed in trunk already → [rtm++]Fixed in trunk already
| Assignee | ||
Comment 27•26 years ago
|
||
will checkin to the branch once my it finishes pulling
Status: REOPENED → ASSIGNED
| Assignee | ||
Comment 28•26 years ago
|
||
Fix checked in to branch.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
Comment 29•26 years ago
|
||
Marking Verified Fixed.
WinNT 20001024
Mac 20001024
Linux 20001024
Status: RESOLVED → VERIFIED
Updated•21 years ago
|
Product: MailNews → Core
Updated•18 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•