Closed
Bug 56200
Opened 26 years ago
Closed 24 years ago
Save As Charset problem
Categories
(Core :: Internationalization, defect, P2)
Tracking
()
VERIFIED
WORKSFORME
People
(Reporter: teruko, Assigned: tetsuroy)
References
()
Details
(Keywords: intl, Whiteboard: [rtm-])
When you try to use Save as Charset dialog, you need to change the charset
something else first and change back to the one you want to save it.
Steps of reproduce
1. Go to above URL
2. Select File|EditPage to open Composer (at this time, you see garbage
characters)
3. Select menu View|Character coding->More->East Asian->Japanese(Shift_JIS)
Now, Japanese characters are displayed correctly.
4. Select menu File|Save as Charset..
In the Save as Charset dialog, Charset is set to Shift_JIS since I selected
Shift_JIS in step #3.
5. Save it as Shift_JIS
In the saved html, the meta-charset is not changed to Shift_JIS.
It remains ISO-8859-1.
To save as Shift_JIS, in step #4, you need to click some other charset first,
then, click Shift_JIS. Then, you can save it as Shift_JIS.
Tested 2000-10-11-08 MN6 build.
Comment 1•26 years ago
|
||
Teruko/Ftang - Is this something you thing we could release note, or is it an
absolute MUST FIX in your mind? (i.e. It is currently marked as P3, hence I
would vote to release note and ship).
Please Advise . . .
| Reporter | ||
Comment 2•26 years ago
|
||
The user have to do extra thing to select charset in Save as Charset dialog.
I think this is not good behavior. We should fix this.
Priority: P3 → P2
| Reporter | ||
Comment 5•25 years ago
|
||
Added nsbeta1 and intl keywords.
Comment 6•25 years ago
|
||
added momoi-san
| Reporter | ||
Comment 7•25 years ago
|
||
Changed QA contact to ylong@netscape.com.
QA Contact: teruko → ylong
Comment 8•25 years ago
|
||
reassing composer related problem to yokoyama.
yokoyama, ask cmanski if you have DOM / JavaScirpt and XUI question.
Assignee: ftang → yokoyama
Comment 9•25 years ago
|
||
I found some new issue with this bug on 01-17 Mtrunk build:
1. With all platform, there is no "Save as Charset" dialog comes out!
2. WindowME-j, you have to create a new profile in order to bring up the Editor
page by going [File]|[Edit Page] in browser, otherwise you won't get or get a
blank Editor page.
| Assignee | ||
Comment 10•25 years ago
|
||
Updating the target milestone.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
| Assignee | ||
Comment 11•25 years ago
|
||
teruko: I need to know the differece between the "Save As..." and "Save As
CharSet..." menu. My understanding was that the "Save As CharSet..." will save
the doc in the specified CharSet and updates the meta charset tag. But it's not
doing that. It's just saving the doc, just like "Save As..." menu. No coversion.
| Assignee | ||
Comment 12•25 years ago
|
||
ylong: can you try this bug again? I was able to reproduce this bug last week;
but I can't do it this week with Momoi-san's machine.
Comment 13•25 years ago
|
||
"Save As Charset" works fine but there is a very tricky part:
In Composer|Editor, when you open a file and go View|Character Coding and
choose a encoding(e.g. Shift-jis) which is different than original page
charset(e.g. iso=88591) in meta-tag, and then go File|Save As Charset select a
charset which is same as the one you just went to View|Character
Coding(shift-jis), then the selected charset in "Save As Charset" can't be saved
cause it has been consider there is no changes(both are shift-jis), and doing
the thing just like "Save" instead of "Save As Charset", so the page encoding
still keep the original charset(iso-88591).
So basically, the "Save as charset" is working and it easy to confuse user.
| Reporter | ||
Comment 14•25 years ago
|
||
The original bug was that the selection of the character set in the Save as
Charset dialog did not stick once you select. You need to choose other
character set first, then, you need to select the one you want to save to.
Roy, if this does not happen anymore, you should close this as fixed.
Before RTM, Brian and I talked about how Save as.. and Save as charset should
work.
Brian, do you have the document which we discuss?
Comment 15•25 years ago
|
||
The problem here is:
The valueChanged callback is what changes the charset.
The SaveAsCharset "Ok" callback does not look at the selected charset.
This means that to actually change the charset the code assumes the user
will *always* click on a new value in the list. If the user changed the
charset from the View->"Character Coding" menu and did not click the
list (because it was already correct) the meta charset is left as it was
*not* as the list indicates.
We need to either:
Get the target encoding from the SaveAsCharset dialog list
or
Set the target encoding before raising the SaveAsCharset.
| Assignee | ||
Updated•25 years ago
|
Target Milestone: mozilla0.9 → ---
| Assignee | ||
Updated•25 years ago
|
Target Milestone: --- → mozilla1.0
| Assignee | ||
Updated•25 years ago
|
Target Milestone: mozilla1.0 → Future
Comment 20•24 years ago
|
||
I checked it on 01-22 trunk build:
it's a little bit block by bug 121304, but seems it works fine with the original
problem.
Comment 21•24 years ago
|
||
Yuyin, could you summarize the remaining problem and either change the summary
or file a separate bug? Is the remaing issue a nsbeta1?
Comment 22•24 years ago
|
||
I'd say the original problem is not reproducible on recent trunk build, it might
related with the check-in of fixed for bug 96759.
Anyway, I think we can resolve this one and I'll file another bug if there is
any problem still existing after bug 121304 fixed.
Comment 23•24 years ago
|
||
This bug contains too many informaiton. Let's minus and close it.
open new bug for other issues.
Comment 24•24 years ago
|
||
Mark verified as works for me for original problem.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•