Closed Bug 562051 Opened 14 years ago Closed 14 years ago

[OOPP] Google Earth plugin for Firefox doesn't work in Minefield 3.7a5pre

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 final+, status1.9.2 unaffected, status1.9.1 unaffected)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
blocking2.0 --- final+
status1.9.2 --- unaffected
status1.9.1 --- unaffected

People

(Reporter: Peter6, Assigned: bent.mozilla)

References

(
URL
)

Details

(Keywords: regression) 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100427 Minefield/3.7a5pre ID:20100427040158

repro:
open FF
open maps.google.com
click on the button labelled [Earth]
You get a message to install the Google Earth plugin
Install it and restart Minefield

go to maps.google.com
click on the button labelled [Earth]
you are suggested to install it again, which needless to say doesn't help
Component: General → Plug-ins
Product: Firefox → Core
QA Contact: general → plugins
Summary: Google Earth plugin for Firefox doesn't work in Minefield 3.7a5pre → [OOPP] Google Earth plugin for Firefox doesn't work in Minefield 3.7a5pre
I'm seeing this on Windows 7 Professional x64 as well with the latest nightly.
and do you see the plugin in about:plugins ?
Does it work in FF3.6.3 or is this only an issue on the trunk ?
I see the following in about:plugins with Minefield:
Google Earth Plugin
File: C:\Program Files (x86)\Google\Google Earth\plugin\npgeplugin.dll
Version: 1.0.0.1
GEPlugin

Just tested with Firefox 3.6.3 under Windows XP and it installs and works just fine.
I just tried this with firefox 3.6.4 build 1 RC and it works fine with dom.ipc.plugins.enabled = false (default), but if you toggle the pref to true and restart the browser on going to maps.google.com an error page loads with the message "There was a problem with the Google Earth Plugin. Please try reloading the page" Toggling the pref back to the default position and restarting the browser the plugin loads fine.

I also tried white-listing the plugin by creating the boolean pref dom.ipc.plugins.enabled.npgeplugin.dll and setting to true. This also failed with the same error message even if dom.ipc.plugins.enabled = false

All on Win 7 X64
Whilst probably not worth asking for blocking 3.6.4 as the plugin works with the default configuration, it may be worth adding a release note that it will stop working if the user flips dom.ipc.plugins.enabled to true. In this case the plugin should be blacklist by creating the pref dom.ipc.plugins.enabled.npgeplugin.dll and setting it to false.

Is there a bugzilla flag requesting rel-note status?
I suspect that this is a plugin crash: is there any entries or pairs of entries in about:crashes around the time you tried google earth?
I suspected too the binary google earth plugin is crashing with OOPP enabled. However there are no entries at all in my about:crashes and I have tested this many times where the plugin fails to load/crashes.
We aren't going to relnote a non-default configuration which can only be reached via about:config.
Build worked : 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a4pre) Gecko/20100323 Minefield/3.7a4pre

Build broken : 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a4pre) Gecko/20100324 Minefield/3.7a4pre

Pushlog : 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e9b7e0b5821d&tochange=e9312d05488f
I reverted to 31176eb8917b in local build. then the local build works.
So, a7c62300bbbb (Bug 547359) causes the problem.
(In reply to comment #8)
> We aren't going to relnote a non-default configuration which can only be
> reached via about:config.

i presume blocking on 1.9.3 depends on whether OOOP is kept enabled for all plugins or whether a whitelist - like on 1.9.2.4+ - is used and thus excluding npgeplugin.dll for OOOP, no?
Blocks: 547359
blocking2.0: --- → ?
Keywords: regression
Assignee: nobody → bent.mozilla
blocking2.0: ? → final+
status1.9.1: --- → unaffected
status1.9.2: --- → unaffected
In my Minefield beta8pre google earth plugin work fine.

about:buildconfig
Source

Built from http://hg.mozilla.org/mozilla-central/rev/d253c44465ae
Build platform
target
i686-pc-mingw32
Build tools
Compiler 	Version 	Compiler flags
d;D:\mozilla-build\msys\mozilla-build\python25\python2.5.exe -O e;D:\mozilla-build\msys\builds\moz2_slave\mozilla-central-win32-nightly\build\build\cl.py cl 	14.00.50727.762 	-TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
d;D:\mozilla-build\msys\mozilla-build\python25\python2.5.exe -O e;D:\mozilla-build\msys\builds\moz2_slave\mozilla-central-win32-nightly\build\build\cl.py cl 	14.00.50727.762 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800 -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
Configure arguments

--enable-application=browser --enable-update-channel=nightly --enable-update-packaging --enable-jemalloc --enable-tests
Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101026 Firefox/4.0b8pre ID:20101026042359

yep WFM too now
WFM,
Fixed by  a1ad34b3cdc2	Benjamin Smedberg — Bug 582012 - register identifiers in the ID maps when they are created by the browser, so that a plugin never sees two identifiers for the same string/integer, r=bent
Status: NEW → RESOLVED
Closed: 14 years ago
Depends on: 582012
Resolution: --- → WORKSFORME
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.