562159 - Tabs from other computers don't show at about:weave-tabs

Status: VERIFIED FIXED

Description

[Tracy Walker [:tracy]]

Created attachment 441919 [details]
activity log of sync on Mac

Seen syncing tabs from 3.6.4b1 on XP to Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.5pre) Gecko/20100427 Namoroka/3.6.5pre

STR:
0) have clients A (XP) and B (Mac) setup on same the same Weave account
1) open a few unique tabs on client A, sync
2) sync client B
3) with only one tab open on client B, open History > Tabs From Other Computers

test results:
No tabs appear on the about:weave-tabs page

expected results:
Display a tab list matching the few unique tabs opened in step 1.

Comment 1

[Tracy Walker [:tracy]]

note: syncing these same machines with new tabs on client B (mac) changes are picked up on client A (XP)

Comment 2

[Ed Lee :Mardak]

Seems like the data got to the mac according to the activity log:

 payload: {"clientName":"work's Firefox on CONECK","tabs":[{"title":"Yahoo!",
2010-04-27 15:32:02	Engine.Tabs          INFO	Records: 1 applied, 0 reconciled, 0 left to fetch

Comment 3

[Ed Lee :Mardak]

Can you check the error console for anything when you open/refresh the tabs page?

Comment 4

[Tracy Walker [:tracy]]

per irc chat. nothing in the error console

chrome://weave/content/fennec-tabs.xhtml loads fine

chrome://weave/content/fx-tabs.xul does not show any tabs

Comment 5

[Tony Chung [:tchung]]

i confirm with weave 1.3b2 on mac.  no sync'd tabs found.

Comment 6

[Mike Connor [:mconnor]]

Created attachment 442225 [details] [diff] [review]
v1

Somehow there are more tab records than client records... so we fail looking up the tab.

Comment 7

[Mike Connor [:mconnor]]

s/the tab/the client/

Comment 8

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/52e7d114a747

Comment 9

[Tracy Walker [:tracy]]

verified with 1.3b3

Comment 10

[Daniel Hahler]

This affected me on 1.2.3, too (with a fresh/first install a few days ago).

Please consider pushing this fix to the stable branch.

Comment 11

[Ed Morley (Away 13-16th and 18th Dec-1st Jan) [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e226e413dd27

Comment 12

[Matt Brubeck (:mbrubeck)]

(In reply to Ed Morley [:edmorley] from comment #11)
> https://hg.mozilla.org/mozilla-central/rev/e226e413dd27

This landed with the wrong bug number; it is actually from bug 562169.