Tabs from other computers don't show at about:weave-tabs

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
9 years ago
6 years ago

People

(Reporter: tracy, Assigned: mconnor)

Tracking

({regression})

unspecified
regression
Points:
---
Bug Flags:
blocking-weave1.3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [weave1.3])

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 441919 [details]
activity log of sync on Mac

Seen syncing tabs from 3.6.4b1 on XP to Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.5pre) Gecko/20100427 Namoroka/3.6.5pre

STR:
0) have clients A (XP) and B (Mac) setup on same the same Weave account
1) open a few unique tabs on client A, sync
2) sync client B
3) with only one tab open on client B, open History > Tabs From Other Computers

test results:
No tabs appear on the about:weave-tabs page

expected results:
Display a tab list matching the few unique tabs opened in step 1.
Flags: blocking-weave1.3?
(Reporter)

Comment 1

9 years ago
note: syncing these same machines with new tabs on client B (mac) changes are picked up on client A (XP)
Seems like the data got to the mac according to the activity log:

 payload: {"clientName":"work's Firefox on CONECK","tabs":[{"title":"Yahoo!",
2010-04-27 15:32:02	Engine.Tabs          INFO	Records: 1 applied, 0 reconciled, 0 left to fetch
Can you check the error console for anything when you open/refresh the tabs page?
(Reporter)

Comment 4

9 years ago
per irc chat. nothing in the error console

chrome://weave/content/fennec-tabs.xhtml loads fine

chrome://weave/content/fx-tabs.xul does not show any tabs

Comment 5

9 years ago
i confirm with weave 1.3b2 on mac.  no sync'd tabs found.
(Assignee)

Comment 6

9 years ago
Created attachment 442225 [details] [diff] [review]
v1

Somehow there are more tab records than client records... so we fail looking up the tab.
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Attachment #442225 - Flags: review?(edilee)
(Assignee)

Comment 7

9 years ago
s/the tab/the client/
Severity: critical → major
Flags: blocking-weave1.3? → blocking-weave1.3+
OS: Mac OS X → All
Hardware: x86 → All
Attachment #442225 - Flags: review?(edilee) → review+
(Assignee)

Comment 8

9 years ago
http://hg.mozilla.org/labs/weave/rev/52e7d114a747
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

9 years ago
verified with 1.3b3
Status: RESOLVED → VERIFIED

Comment 10

9 years ago
This affected me on 1.2.3, too (with a fresh/first install a few days ago).

Please consider pushing this fix to the stable branch.
(In reply to Ed Morley [:edmorley] from comment #11)
> https://hg.mozilla.org/mozilla-central/rev/e226e413dd27

This landed with the wrong bug number; it is actually from bug 562169.
You need to log in before you can comment on or make changes to this bug.