Closed Bug 562159 Opened 11 years ago Closed 11 years ago

Tabs from other computers don't show at about:weave-tabs

Categories

(Firefox :: Sync, defect)

defect
Not set
major

Tracking

()

VERIFIED FIXED

People

(Reporter: tracy, Assigned: mconnor)

Details

(Keywords: regression, Whiteboard: [weave1.3])

Attachments

(2 files)

Seen syncing tabs from 3.6.4b1 on XP to Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.5pre) Gecko/20100427 Namoroka/3.6.5pre

STR:
0) have clients A (XP) and B (Mac) setup on same the same Weave account
1) open a few unique tabs on client A, sync
2) sync client B
3) with only one tab open on client B, open History > Tabs From Other Computers

test results:
No tabs appear on the about:weave-tabs page

expected results:
Display a tab list matching the few unique tabs opened in step 1.
Flags: blocking-weave1.3?
note: syncing these same machines with new tabs on client B (mac) changes are picked up on client A (XP)
Seems like the data got to the mac according to the activity log:

 payload: {"clientName":"work's Firefox on CONECK","tabs":[{"title":"Yahoo!",
2010-04-27 15:32:02	Engine.Tabs          INFO	Records: 1 applied, 0 reconciled, 0 left to fetch
Can you check the error console for anything when you open/refresh the tabs page?
per irc chat. nothing in the error console

chrome://weave/content/fennec-tabs.xhtml loads fine

chrome://weave/content/fx-tabs.xul does not show any tabs
i confirm with weave 1.3b2 on mac.  no sync'd tabs found.
Attached patch v1Splinter Review
Somehow there are more tab records than client records... so we fail looking up the tab.
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Attachment #442225 - Flags: review?(edilee)
s/the tab/the client/
Severity: critical → major
Flags: blocking-weave1.3? → blocking-weave1.3+
OS: Mac OS X → All
Hardware: x86 → All
Attachment #442225 - Flags: review?(edilee) → review+
http://hg.mozilla.org/labs/weave/rev/52e7d114a747
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
verified with 1.3b3
Status: RESOLVED → VERIFIED
This affected me on 1.2.3, too (with a fresh/first install a few days ago).

Please consider pushing this fix to the stable branch.
(In reply to Ed Morley [:edmorley] from comment #11)
> https://hg.mozilla.org/mozilla-central/rev/e226e413dd27

This landed with the wrong bug number; it is actually from bug 562169.
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.