Last Comment Bug 562289 - Using a system proxy ignores socks_remote_dns pref
: Using a system proxy ignores socks_remote_dns pref
Product: Core
Classification: Components
Component: Networking (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla11
Assigned To: Matt Woodrow (:mattwoodrow)
: Patrick McManus [:mcmanus]
Depends on:
  Show dependency treegraph
Reported: 2010-04-28 01:39 PDT by Matt Woodrow (:mattwoodrow)
Modified: 2012-02-01 13:57 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix (916 bytes, patch)
2010-04-28 01:52 PDT, Matt Woodrow (:mattwoodrow)
cbiesinger: review+
Details | Diff | Splinter Review

Description Matt Woodrow (:mattwoodrow) 2010-04-28 01:39:47 PDT
It looks like nsProtocolProxyService::Resolve_Internal never checks the value of mSOCKSProxyRemoteDNS when setting up a proxy.
Comment 1 Matt Woodrow (:mattwoodrow) 2010-04-28 01:52:26 PDT
Created attachment 442040 [details] [diff] [review]

Tested this and it works fine. Not sure who to ask for a review on this.
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2010-04-28 09:07:30 PDT
Er, I meant to say:

I don't really know this code.  Jason, do you?  Or do we need to get Christian or Honza to look at this?
Comment 3 Jason Duell [:jduell] (needinfo me) 2010-04-28 10:28:27 PDT
Comment on attachment 442040 [details] [diff] [review]

I don't know SOCKS at all.  Biesi, this is a one-liner--can you look?
Comment 4 Christian :Biesinger (don't email me, ping me on IRC) 2010-07-15 19:18:01 PDT
So... there is some discussion about this in and several following comments.
Comment 5 Christian :Biesinger (don't email me, ping me on IRC) 2011-11-16 11:33:13 PST
Comment on attachment 442040 [details] [diff] [review]

but I think this patch is a good idea.
Comment 7 Ed Morley [:emorley] 2011-11-20 14:21:53 PST

Note You need to log in before you can comment on or make changes to this bug.