importxml.pl should import each comment separately, rather than concatenating them all into a single one

RESOLVED FIXED in Bugzilla 4.2

Status

()

--
enhancement
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: fabian, Assigned: LpSolit)

Tracking

Bugzilla 4.2
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.18) Gecko/2010021619 Camino/2.0.2 (like Firefox/3.0.18)
Build Identifier: Bugzilla-3.6

importxml.pl currently aggregates all comments into the description field of the bug, with text markings to report on the original reporter (who) and time of the imported comments.  The reason behind this seems to be (from comments) that original reporters may not exist in the system being imported in.

Reproducible: Always

Steps to Reproduce:
1. save xml output of a bug
2. importxml.pl that output

Actual Results:  
see comments being aggregated as a single message in the description of the imported bug

Expected Results:  
allow in some way to post separate comments to the bug to as close as possible reproduce the original bug.

I have a patch which implements this behaviour based on a command line switch "--post_comments".  I will attach the patch in the next comment.
(Reporter)

Comment 1

9 years ago
Created attachment 442050 [details] [diff] [review]
importxml post-comments implementation

Patch to implement posting real comments to each bug, instead of aggregating in the description.  I decided to retain the original behaviour, as it probably has some good usage too.  Result is a bit if/then/else-like code.

If separate comments are to be posted, each reporter is looked up.  If they don't exist, a remark is prepended to the comment message with the original reporter id/email and the reporter is set to the exporter's id.  The status message about the import is made a final comment on the bug as well in --post_comments mode.
(Assignee)

Comment 2

9 years ago
Comment on attachment 442050 [details] [diff] [review]
importxml post-comments implementation

Putting this patch in our radar.
Attachment #442050 - Flags: review?
(Assignee)

Comment 3

8 years ago
I'm actually interested to see this implemented. I will go even farther and say that there is no need for a switch. This should be the default behavior. And I like you proposal: use the original comment reporter, else fall back to the exporter.

Fabian, are you interested in updating your patch this way?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 4.2
Version: unspecified → 3.6
(Assignee)

Updated

8 years ago
Summary: importxml.pl: add support for posting bug comments → importxml.pl should import each comment separately, rather than concatenating them all into a single one
(Assignee)

Comment 4

8 years ago
Comment on attachment 442050 [details] [diff] [review]
importxml post-comments implementation

Cancelling request for review per my previous comment. When you attach your updated patch, feel free to ask me for review. I would be happy to test your patch. :)
Attachment #442050 - Flags: review?
(Reporter)

Comment 5

8 years ago
I only needed this for a one-time conversion phase.  I hereby allow you to change the patch in any way to suit your liking.  I think it's fairly straight-forward to remove all the if-cases to make post-comments the only option, or just to add an "aggregate-comments" option to achieve the inverse.

If you really need me to update the patch for you to commit it, tell me exactly how you want it, and I'll attach it.
(Assignee)

Comment 6

8 years ago
OK, that's fine. I will do it. Thanks :)
(Assignee)

Comment 7

8 years ago
Created attachment 482362 [details] [diff] [review]
patch, v1

My patch also fixes another bug I found while testing it. %X writes the time in the 12 hours format, instead of the 24h format (i.e. 4pm was displayed as 04:00:00 instead of 16:00:00). So we want %T here.
Assignee: import-export → LpSolit
Attachment #442050 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #482362 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #482362 - Flags: review? → review?(gregaryh)

Updated

8 years ago
Attachment #482362 - Flags: review?(gregaryh) → review+
(Assignee)

Updated

8 years ago
Flags: approval+
(Assignee)

Comment 8

8 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified importxml.pl
Committed revision 7528.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: relnote
Resolution: --- → FIXED
(Assignee)

Comment 9

7 years ago
Added to relnotes in bug 713346.
Keywords: relnote
(Assignee)

Updated

5 years ago
Blocks: 848063
You need to log in before you can comment on or make changes to this bug.