562314 - importxml.pl: add support for a different bug page in URLs

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, enhancement)

Description

[Fabian Groffen]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en; rv:1.9.0.18) Gecko/2010021619 Camino/2.0.2 (like Firefox/3.0.18)
Build Identifier: Bugzilla-3.6

importxml currently generates hardcoded URLs to $urlbase . "show_bug.cgi?id=" for bug numbers.  It may be handy to be able to change this, e.g. for hosts that do fancy (and favour) url mapping (bugs.g.o/1234), or when migrating from another bugtracker, such as sourceforge (as I'm currently doing) where the $urlbase points to sourceforge, and the bugpage simply needs to be "tracker.php?aid=".

Reproducible: Always

Steps to Reproduce:
1. importxml.pl
2. review bug
3.
Actual Results:  
hardcoded bugzilla show_bug page

Expected Results:  
ability to configure what page to use

I created a patch that implements this partly, by making the bug page configurable, requiring that the bug number can always be appended to the end.  I will attach the patch shortly.

Comment 1

[Fabian Groffen]

Attachment: importxml bug_page implementation

Patch to allow the bug page ("show_bug.cgi?id=") to be changed to something else, such that urls can be made that resemble other bugtracking systems (for migration purposes).  It works with a --bug_page flag that accepts a string argument to take instead of "show_bug.cgi?id=".  It defaults to the latter when not given.

Comment 2

[Frédéric Buclin]

Comment on attachment 442058 [details] [diff] [review]
importxml bug_page implementation

Putting this patch in our radar.

Comment 3

[Max Kanat-Alexander]

FWIW, if you're importing from another bug-tracking system, migrate.pl is the more appropriate system to use, if you can.

Comment 4

[Frédéric Buclin]

Comment on attachment 442058 [details] [diff] [review]
importxml bug_page implementation

>+        my $url = $urlbase . $bug_page;

$url should be defined at the top of process_bug() and be used everywhere. I will do it on checkin. Thanks for your contribution! :) r=LpSolit

Comment 5

[Frédéric Buclin]

Comment on attachment 442058 [details] [diff] [review]
importxml bug_page implementation

>+        my $url = $urlbase . $bug_page;

Actually, the patch doesn't work. First of all, it doesn't apply cleanly, and secondly, $bug_page must be detainted. I'm going to fix that myself.

Comment 6

[Frédéric Buclin]

Attachment: patch, v2

Here is a working patch.

Comment 7

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified importxml.pl
Committed revision 8253.