562319 - test_sibling-matching-parent.html and test_bug270414.html fail intermittently due to xpcWaitForFinishedFrames in NavigationUtils.js assuming that data: URLs are parsed synchronously

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Henri Sivonen (:hsivonen)]

After enabling the HTML5 parser on the real tinderbox, test_sibling-matching-parent.html fails intermittently due to NavigationUtils.js accessing document.body without a null check.

This didn't show up on the tryserver. The test passes if document.body exists by the time the script tries to access it and fails if the body element hasn't yet been inserted into the DOM by the parser.

Comment 1

[Henri Sivonen (:hsivonen)]

Also:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272463095.1272464622.8870.gz
185 INFO TEST-PASS | /tests/docshell/test/navigation/test_bug270414.html |
Should be able to navigate on-domain opener's children by setting location.
186 INFO TEST-PASS | /tests/docshell/test/navigation/test_bug270414.html |
Should be able to navigate on-domain opener's children by calling window.open.
187 INFO TEST-PASS | /tests/docshell/test/navigation/test_bug270414.html |
Should be able to navigate on-domain opener's children by submitting form.
188 ERROR TEST-UNEXPECTED-FAIL |
/tests/docshell/test/navigation/test_bug270414.html | Should be able to
navigate on-domain opener's children by targeted hyperlink. - got TypeError:
wnd.document.body is null, expected "This frame was navigated."

Comment 2

[Henri Sivonen (:hsivonen)]

The problem is that xpcWaitForFinishedFrames doesn't really wait for the frames to finish but waits for their window.location to become the target (data:) URL.

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Potential fix

Needs a couple of tryserver runs still.

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 442352 [details] [diff] [review]
Potential fix

The tryserver isn't cooperating, so requesting review based on local testing only.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 442352 [details] [diff] [review]
Potential fix

r=bzbarsky

Comment 6

[Henri Sivonen (:hsivonen)]

http://hg.mozilla.org/mozilla-central/rev/64488a668662